Tips linking to https://phpstan.org/blog/why-array-string-keys-are-not-type-safe

Author: ondrejmirtes

src/Rules/Playground/ArrayDimCastRule.php

@@ -53,6 +53,7 @@ public function processNode(Node $node, Scope $scope): array
 				$arrayKeyType->describe(VerbosityLevel::value()),
 				$arrayKeyType->describe(VerbosityLevel::typeOnly()),
 			))->identifier('phpstanPlayground.arrayDimFetchCast')
+				->tip('Learn more: <fg=cyan>https://phpstan.org/blog/why-array-string-keys-are-not-type-safe</>')
 				->build();
 		}
 

src/Rules/Playground/LiteralArrayKeyCastRule.php

@@ -49,6 +49,7 @@ public function processNode(Node $node, Scope $scope): array
 					$arrayKeyType->describe(VerbosityLevel::value()),
 					$arrayKeyType->describe(VerbosityLevel::typeOnly()),
 				))->identifier('phpstanPlayground.arrayKeyCast')
+					->tip('Learn more: <fg=cyan>https://phpstan.org/blog/why-array-string-keys-are-not-type-safe</>')
 					->line($item->getStartLine())
 					->build();
 			}

tests/PHPStan/Rules/Playground/ArrayDimCastRuleTest.php

@@ -18,34 +18,42 @@ protected function getRule(): Rule
 
 	public function testRule(): void
 	{
+		$tip = 'Learn more: <fg=cyan>https://phpstan.org/blog/why-array-string-keys-are-not-type-safe</>';
 		$this->analyse([__DIR__ . '/data/array-dim-fetch-cast.php'], [
 			[
 				"Key '1' (string) will be cast to 1 (int) in the array access.",
 				13,
+				$tip,
 			],
 			[
 				"Key null (null) will be cast to '' (string) in the array access.",
 				14,
+				$tip,
 			],
 			[
 				'Key 2.5 (float) will be cast to 2 (int) in the array access.',
 				15,
+				$tip,
 			],
 			[
 				'Key true (bool) will be cast to 1 (int) in the array access.',
 				17,
+				$tip,
 			],
 			[
 				'Key false (bool) will be cast to 0 (int) in the array access.',
 				18,
+				$tip,
 			],
 			[
 				"Key '10' (string) will be cast to 10 (int) in the array access.",
 				20,
+				$tip,
 			],
 			[
 				"Key '1' (string) will be cast to 1 (int) in the array access.",
 				26,
+				$tip,
 			],
 		]);
 	}

tests/PHPStan/Rules/Playground/LiteralArrayKeyCastRuleTest.php

@@ -18,30 +18,37 @@ protected function getRule(): Rule
 
 	public function testRule(): void
 	{
+		$tip = 'Learn more: <fg=cyan>https://phpstan.org/blog/why-array-string-keys-are-not-type-safe</>';
 		$this->analyse([__DIR__ . '/data/literal-array-key-cast.php'], [
 			[
 				"Key '1' (string) will be cast to 1 (int) in the array.",
 				14,
+				$tip,
 			],
 			[
 				"Key null (null) will be cast to '' (string) in the array.",
 				15,
+				$tip,
 			],
 			[
 				'Key 2.5 (float) will be cast to 2 (int) in the array.',
 				16,
+				$tip,
 			],
 			[
 				'Key true (bool) will be cast to 1 (int) in the array.',
 				18,
+				$tip,
 			],
 			[
 				'Key false (bool) will be cast to 0 (int) in the array.',
 				19,
+				$tip,
 			],
 			[
 				"Key '10' (string) will be cast to 10 (int) in the array.",
 				21,
+				$tip,
 			],
 		]);
 	}