Skip to content

Commit 528b1a7

Browse files
committed
pkg/executor: use sqlDigest key in MPP dispatch logs
1 parent a4f0da2 commit 528b1a7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

pkg/executor/internal/mpp/local_mpp_coordinator.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ func (c *localMppCoordinator) appendMPPDispatchReq(pf *physicalop.Fragment, allT
249249
zap.String("exchange-compression-mode", pf.Sink.GetCompressionMode().Name()),
250250
zap.Uint64("GatherID", c.gatherID),
251251
zap.String("resource_group", rgName),
252-
zap.String("sql_digest", sqlDigest),
252+
zap.String("sqlDigest", sqlDigest),
253253
)
254254
req := &kv.MPPDispatchRequest{
255255
Data: pbData,
@@ -613,14 +613,14 @@ func (c *localMppCoordinator) handleDispatchReq(ctx context.Context, bo *backoff
613613
})
614614
if retry {
615615
// TODO: If we want to retry, we might need to redo the plan fragment cutting and task scheduling. https://github.com/pingcap/tidb/issues/31015
616-
logutil.BgLogger().Warn("mpp dispatch meet error and retrying", zap.Error(err), zap.Uint64("timestamp", c.startTS), zap.Int64("task", req.ID), zap.Int64("mpp-version", req.MppVersion.ToInt64()), zap.String("sql_digest", req.SQLDigest))
616+
logutil.BgLogger().Warn("mpp dispatch meet error and retrying", zap.Error(err), zap.Uint64("timestamp", c.startTS), zap.Int64("task", req.ID), zap.Int64("mpp-version", req.MppVersion.ToInt64()), zap.String("sqlDigest", req.SQLDigest))
617617
continue
618618
}
619619
break
620620
}
621621

622622
if err != nil {
623-
logutil.BgLogger().Warn("mpp dispatch meet error", zap.String("error", err.Error()), zap.Uint64("timestamp", req.StartTs), zap.Int64("task", req.ID), zap.Int64("mpp-version", req.MppVersion.ToInt64()), zap.String("sql_digest", req.SQLDigest))
623+
logutil.BgLogger().Warn("mpp dispatch meet error", zap.String("error", err.Error()), zap.Uint64("timestamp", req.StartTs), zap.Int64("task", req.ID), zap.Int64("mpp-version", req.MppVersion.ToInt64()), zap.String("sqlDigest", req.SQLDigest))
624624
atomic.CompareAndSwapUint32(&c.dispatchFailed, 0, 1)
625625
// if NeedTriggerFallback is true, we return timeout to trigger tikv's fallback
626626
if c.needTriggerFallback {
@@ -631,7 +631,7 @@ func (c *localMppCoordinator) handleDispatchReq(ctx context.Context, bo *backoff
631631
}
632632

633633
if rpcResp.Error != nil {
634-
logutil.BgLogger().Warn("mpp dispatch response meet error", zap.String("error", rpcResp.Error.Msg), zap.Uint64("timestamp", req.StartTs), zap.Int64("task", req.ID), zap.Int64("task-mpp-version", req.MppVersion.ToInt64()), zap.Int64("error-mpp-version", rpcResp.Error.GetMppVersion()), zap.String("sql_digest", req.SQLDigest))
634+
logutil.BgLogger().Warn("mpp dispatch response meet error", zap.String("error", rpcResp.Error.Msg), zap.Uint64("timestamp", req.StartTs), zap.Int64("task", req.ID), zap.Int64("task-mpp-version", req.MppVersion.ToInt64()), zap.Int64("error-mpp-version", rpcResp.Error.GetMppVersion()), zap.String("sqlDigest", req.SQLDigest))
635635
atomic.CompareAndSwapUint32(&c.dispatchFailed, 0, 1)
636636
c.sendError(errors.New(rpcResp.Error.Msg))
637637
return

0 commit comments

Comments
 (0)