fix(server): an advisory failure keeps the owed gate checks

Only a new gate failure re-arms the owed set; a new advisory failure no
longer owes gate checks that started after the gate failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: Rhinomcd

apps/server/src/orchestration-v2/pullRequestWatch.test.ts

@@ -287,6 +287,20 @@ describe("evaluatePullRequestWatch", () => {
       "- The checks still running when one failed have finished on aaaaaaa. Still failing:\n  - lint https://ci.example/lint",
     );
 
+    // A new advisory failure keeps what was owed rather than owing a required check started since.
+    const advisory = detail({
+      checks: [
+        required("lint", "failure"),
+        required("unit", "pending"),
+        required("smoke", "pending"),
+        check("bot", "failure"),
+        check("e2e", "failure"),
+      ],
+    });
+    const later = evaluatePullRequestWatch(first.next, advisory, noRemarks);
+    assert.deepEqual(later.changes, [{ kind: "checks-failed", failed: [check("e2e", "failure")] }]);
+    assert.deepEqual(later.next.owedChecks, ["unit"]);
+
     // A rerun of the failed required check is not the gate finishing, even with an advisory failure.
     const rerun = detail({
       checks: [

apps/server/src/orchestration-v2/pullRequestWatch.ts

@@ -90,8 +90,8 @@ export function evaluatePullRequestWatch(
       // Gate checks still running when one failed are owed one wake when they finish, since
       // the gate can no longer pass and so never sends the checks-passed wake.
       const running = gate.filter((check) => check.status === "pending").map((check) => check.name);
-      owedChecks =
-        newlyFailed.length > 0 ? running : owedBefore.filter((name) => running.includes(name));
+      const gateNewlyFailed = newlyFailed.some((check) => gateNames.includes(check.name));
+      owedChecks = gateNewlyFailed ? running : owedBefore.filter((name) => running.includes(name));
       if (newlyFailed.length === 0 && owedBefore.length > 0 && owedChecks.length === 0) {
         changes.push({ kind: "checks-finished", failing: gate.filter(isFailedCheck) });
       }