Skip to content

Refactor KotlinPsiFileFactory to KotlinCompiler#2951

Merged
paul-dingemans merged 3 commits into
masterfrom
refactor-KotlinPsiFileFactory
Mar 22, 2025
Merged

Refactor KotlinPsiFileFactory to KotlinCompiler#2951
paul-dingemans merged 3 commits into
masterfrom
refactor-KotlinPsiFileFactory

Conversation

@paul-dingemans
Copy link
Copy Markdown
Member

Description

Remove workaround for Kotlin Compiler version 1.6 on Java 1.8 (see #1271) which requires KtlintRuleEngine to be injected. The problem of #1271, can still be reproduced with Ktlint 0.43.0 on java 1.8.0_432. With Ktlint 0.44.0 until 1.5.0 which included the workaround, the problem can not be reproduced on that same java version. Without the workaround on that same java version, the problem is also resolved. So, the workaround is no longer needed as it has been resolved in a Kotlin version after 1.6.0.

By removing this workaround, the code is simplified.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Remove workaround for Kotlin Compiler version 1.6 on Java 1.8 (see #1271) which requires KtlintRuleEngine to be injected. The problem of #1271, can still be reproduced with Ktlint 0.43.0 on java 1.8.0_432. With Ktlint 0.44.0 until 1.5.0 which included the workaround, the problem can not be reproduced on that same java version. Without the workaround on that same java version, the problem is also resolved. So, the workaround is no longer needed as it has been resolved in a Kotlin version after 1.6.0.

By removing this workaround, the code is simplified.
@paul-dingemans paul-dingemans added this to the 1.6 milestone Mar 16, 2025
Remove workaround for Kotlin Compiler version 1.6 on Java 1.8 (see #1271) which requires KtlintRuleEngine to be injected. The problem of #1271, can still be reproduced with Ktlint 0.43.0 on java 1.8.0_432. With Ktlint 0.44.0 until 1.5 which included the workaround, the problem can not be reproduced on that same java versionn. Without the workaround on that same java version, the problem is also resolved. So, the workaround is no longer needed as it has been resolved in a Kotlint version after 1.6.0.

By removing this workaround, the code is simplified.
This reduces the number of conversions between "psi" and ASTNode. Also, the code is simplified
@paul-dingemans paul-dingemans merged commit 3c537bf into master Mar 22, 2025
@paul-dingemans paul-dingemans deleted the refactor-KotlinPsiFileFactory branch June 1, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant