Skip to content

add a few minor tests#2981

Merged
marvinhagemeister merged 1 commit intopreactjs:masterfrom
43081j:some-tests
Feb 7, 2021
Merged

add a few minor tests#2981
marvinhagemeister merged 1 commit intopreactjs:masterfrom
43081j:some-tests

Conversation

@43081j
Copy link
Copy Markdown
Contributor

@43081j 43081j commented Feb 6, 2021

its not much but i just wanted to get my head around the source and figured filling a couple of minor gaps in might help.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.441% when pulling 81765e8 on 43081j:some-tests into c71a02f on preactjs:master.

@developit
Copy link
Copy Markdown
Member

Nice! We were actually just talking about removing defaultProps support in #2977, but realized it's still fairly widely used for class-based components. These tests seem handy.

Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🙌

@marvinhagemeister marvinhagemeister merged commit bd10bf5 into preactjs:master Feb 7, 2021
@43081j 43081j deleted the some-tests branch February 7, 2021 10:07
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants