Skip to content

Tests: Fix Chrome 88 stack traces displayed wrong in terminal#3008

Merged
marvinhagemeister merged 2 commits intomasterfrom
karma-stack-traces
Feb 13, 2021
Merged

Tests: Fix Chrome 88 stack traces displayed wrong in terminal#3008
marvinhagemeister merged 2 commits intomasterfrom
karma-stack-traces

Conversation

@marvinhagemeister
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister commented Feb 13, 2021

Starting with Chrome 88 the stack trace format has changed a bit. The new version of errorstacks adds support for parsing that.

Before:

Screenshot 2021-02-13 at 08 50 57

After:

Screenshot 2021-02-13 at 08 50 48

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 13, 2021

Coverage Status

Coverage remained the same at 99.445% when pulling f99902d on karma-stack-traces into dcdc32a on master.

Copy link
Copy Markdown
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marvinhagemeister marvinhagemeister merged commit 6c263a8 into master Feb 13, 2021
@marvinhagemeister marvinhagemeister deleted the karma-stack-traces branch February 13, 2021 18:06
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants