Tests: Reduce CPU usage in watch mode#3011
Merged
marvinhagemeister merged 1 commit intomasterfrom Feb 13, 2021
Merged
Conversation
andrewiggins
approved these changes
Feb 13, 2021
marvinhagemeister
force-pushed
the
karma-esbuild-update
branch
from
ecd20f4 to
13468ee
Compare
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a performance problem found in
karma-esbuildwhere we were spawning moreesbuildinstances than needed. The new version ofkarma-esbuildswitches back tochokidarfor file watching as it consumes significantly less CPU resources due to relying on native filesystem events instead of a generic polling approach like in esbuild.See marvinhagemeister/karma-esbuild#4 for more information.