Add fix for building against node 10 and 11 (#48)

mathiask88 · web-flow · commit d5a1bccdc6e8 · 2020-11-18T23:19:26.000+01:00
diff --git a/index.js b/index.js
@@ -189,6 +189,9 @@ function build (target, runtime, opts, cb) {
   if (runtime === 'electron') {
     args.push('--runtime=electron')
     args.push('--dist-url=https://atom.io/download/electron')
+  } else if (runtime === 'node' && [10, 11].some(buggedMajor => +target.split('.')[0] === buggedMajor)) {
+    // work around a build bug in node versions 10 and 11 https://github.com/nodejs/node-gyp/issues/1457
+    args.push('--build_v8_with_gn=false')
   }
 
   if (opts.debug) {

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,9 @@ function build (target, runtime, opts, cb) {`
`189`	`189`	`if (runtime === 'electron') {`
`190`	`190`	`args.push('--runtime=electron')`
`191`	`191`	`args.push('--dist-url=https://atom.io/download/electron')`
	`192`	`+ } else if (runtime === 'node' && [10, 11].some(buggedMajor => +target.split('.')[0] === buggedMajor)) {`
	`193`	`+ // work around a build bug in node versions 10 and 11 https://github.com/nodejs/node-gyp/issues/1457`
	`194`	`+ args.push('--build_v8_with_gn=false')`
`192`	`195`	`}`
`193`	`196`
`194`	`197`	`if (opts.debug) {`