Skip to content

Comments

fix(windows): add loading spinner when killing process#77

Merged
productdevbook merged 1 commit intoproductdevbook:mainfrom
mazenS1:fix/process-kill-feedback-not-showing
Jan 30, 2026
Merged

fix(windows): add loading spinner when killing process#77
productdevbook merged 1 commit intoproductdevbook:mainfrom
mazenS1:fix/process-kill-feedback-not-showing

Conversation

@mazenS1
Copy link
Contributor

@mazenS1 mazenS1 commented Jan 3, 2026

Problem

When clicking the X button and confirming "Yes" to kill a process, there was no visual feedback that the operation was in progress.

Solution

Wire up the existing IsKilling property to the UI:

  • Show animated spinner while process is being killed
  • Hide kill button during the operation

20260103-1700-07 7875475

Context

The IsKilling property existed in:

  • Models/PortInfo.cs (lines 77-88) - the property definition
  • ViewModels/MainViewModel.cs (line 191) - sets IsKilling = true before killing

Changes

  • platforms/windows/PortKiller/MainWindow.xaml

Notes

  • No new dependencies
  • Uses existing InverseBoolToVisibilityConverter from the codebase

@dinesh-kondapalli
Copy link
Collaborator

Sure, i will look into this and fix it @productdevbook

@dinesh-kondapalli
Copy link
Collaborator

LGTM - Properly implements loading spinner for kill operation

Copy link
Collaborator

@dinesh-kondapalli dinesh-kondapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a timer icon after clicking the kill button no spinner needed

@productdevbook productdevbook merged commit 3e0f7fc into productdevbook:main Jan 30, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants