fix(windows): add loading spinner when killing process#77
Merged
productdevbook merged 1 commit intoproductdevbook:mainfrom Jan 30, 2026
Merged
Conversation
Collaborator
|
Sure, i will look into this and fix it @productdevbook |
dinesh-kondapalli
approved these changes
Jan 23, 2026
Collaborator
|
LGTM - Properly implements loading spinner for kill operation |
Collaborator
dinesh-kondapalli
left a comment
There was a problem hiding this comment.
there is a timer icon after clicking the kill button no spinner needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When clicking the X button and confirming "Yes" to kill a process, there was no visual feedback that the operation was in progress.
Solution
Wire up the existing
IsKillingproperty to the UI:Context
The
IsKillingproperty existed in:Models/PortInfo.cs(lines 77-88) - the property definitionViewModels/MainViewModel.cs(line 191) - setsIsKilling = truebefore killingChanges
platforms/windows/PortKiller/MainWindow.xamlNotes
InverseBoolToVisibilityConverterfrom the codebase