Skip to content

Commit 1176976

Browse files
fessehaevebzbarsky-apple
authored and
pull[bot]
committed
Identify cluster XML update (#26738)
* update Identify cluster XML and generate code * cleaned up identify server implementation * update generated code references in Identify cluster examples * avoid using namespace in header and update identify init signature * update last pieces of legacy identify generated code * update missed references to legacy generated code * fix typo * fixed logging errors * update namespace usage * fixed few more namespace usage and cast * few more missed namespace updates * Update examples/chef/efr32/src/AppTask.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update examples/light-switch-app/silabs/efr32/src/AppTask.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * address PR comments * regenerate code after removing feature map from XML and running zap_convert_all.py * fix CI errors * trying to fix types * added missing namespace * No need for spurious changes. And for a 16-bit int, 0x00 is not any more "correct" than 0x0. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Revert warning fixes which are not neccessary * shorten namespace use * run restyler * regen Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * fix spell check * Fix new pump-app example. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
1 parent c9dcad3 commit 1176976

173 files changed

Lines changed: 1196 additions & 1183 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎examples/all-clusters-app/all-clusters-common/all-clusters-app.matter‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ struct LabelStruct {
1313

1414
/** Attributes and commands for putting a device into Identification mode (e.g. flashing a light). */
1515
server cluster Identify = 3 {
16-
enum IdentifyEffectIdentifier : ENUM8 {
16+
enum EffectIdentifierEnum : ENUM8 {
1717
kBlink = 0;
1818
kBreathe = 1;
1919
kOkay = 2;
@@ -22,21 +22,21 @@ server cluster Identify = 3 {
2222
kStopEffect = 255;
2323
}
2424

25-
enum IdentifyEffectVariant : ENUM8 {
25+
enum EffectVariantEnum : ENUM8 {
2626
kDefault = 0;
2727
}
2828

29-
enum IdentifyIdentifyType : ENUM8 {
29+
enum IdentifyTypeEnum : ENUM8 {
3030
kNone = 0;
31-
kVisibleLight = 1;
32-
kVisibleLED = 2;
31+
kLightOutput = 1;
32+
kVisibleIndicator = 2;
3333
kAudibleBeep = 3;
3434
kDisplay = 4;
3535
kActuator = 5;
3636
}
3737

3838
attribute int16u identifyTime = 0;
39-
readonly attribute enum8 identifyType = 1;
39+
readonly attribute IdentifyTypeEnum identifyType = 1;
4040
readonly attribute command_id generatedCommandList[] = 65528;
4141
readonly attribute command_id acceptedCommandList[] = 65529;
4242
readonly attribute event_id eventList[] = 65530;
@@ -49,8 +49,8 @@ server cluster Identify = 3 {
4949
}
5050

5151
request struct TriggerEffectRequest {
52-
IdentifyEffectIdentifier effectIdentifier = 0;
53-
IdentifyEffectVariant effectVariant = 1;
52+
EffectIdentifierEnum effectIdentifier = 0;
53+
EffectVariantEnum effectVariant = 1;
5454
}
5555

5656
command access(invoke: manage) Identify(IdentifyRequest): DefaultSuccess = 0;

‎examples/all-clusters-app/all-clusters-common/all-clusters-app.zap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
"code": 1,
112112
"mfgCode": null,
113113
"side": "server",
114-
"type": "enum8",
114+
"type": "IdentifyTypeEnum",
115115
"included": 1,
116116
"storageOption": "RAM",
117117
"singleton": 0,
@@ -9097,7 +9097,7 @@
90979097
"code": 1,
90989098
"mfgCode": null,
90999099
"side": "server",
9100-
"type": "enum8",
9100+
"type": "IdentifyTypeEnum",
91019101
"included": 1,
91029102
"storageOption": "RAM",
91039103
"singleton": 0,

‎examples/all-clusters-app/ameba/main/chipinterface.cpp‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
#endif
4949

5050
using namespace ::chip;
51+
using namespace ::chip::app;
5152
using namespace ::chip::DeviceManager;
5253
using namespace ::chip::DeviceLayer;
5354
using namespace ::chip::System;
@@ -73,17 +74,17 @@ void OnIdentifyTriggerEffect(Identify * identify)
7374
{
7475
switch (identify->mCurrentEffectIdentifier)
7576
{
76-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK:
77-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK");
77+
case Clusters::Identify::EffectIdentifierEnum::kBlink:
78+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kBlink");
7879
break;
79-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE:
80-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE");
80+
case Clusters::Identify::EffectIdentifierEnum::kBreathe:
81+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kBreathe");
8182
break;
82-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY:
83-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY");
83+
case Clusters::Identify::EffectIdentifierEnum::kOkay:
84+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kOkay");
8485
break;
85-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE:
86-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE");
86+
case Clusters::Identify::EffectIdentifierEnum::kChannelChange:
87+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kChannelChange");
8788
break;
8889
default:
8990
ChipLogProgress(Zcl, "No identifier effect");
@@ -96,15 +97,15 @@ Identify gIdentify0 = {
9697
chip::EndpointId{ 0 },
9798
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStart"); },
9899
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStop"); },
99-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
100+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
100101
OnIdentifyTriggerEffect,
101102
};
102103

103104
Identify gIdentify1 = {
104105
chip::EndpointId{ 1 },
105106
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStart"); },
106107
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStop"); },
107-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
108+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
108109
OnIdentifyTriggerEffect,
109110
};
110111

‎examples/all-clusters-app/ameba/main/include/IdentifyCommand.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ void ProcessIdentifyUnicastBindingCommand(BindingCommandData * data, const Ember
9696
break;
9797

9898
case Clusters::Identify::Commands::TriggerEffect::Id:
99-
triggerEffectCommand.effectIdentifier = static_cast<EmberAfIdentifyEffectIdentifier>(data->args[0]);
100-
triggerEffectCommand.effectVariant = static_cast<EmberAfIdentifyEffectVariant>(data->args[1]);
99+
triggerEffectCommand.effectIdentifier = static_cast<Clusters::Identify::EffectIdentifierEnum>(data->args[0]);
100+
triggerEffectCommand.effectVariant = static_cast<Clusters::Identify::EffectVariantEnum>(data->args[1]);
101101
Controller::InvokeCommandRequest(peer_device->GetExchangeManager(), peer_device->GetSecureSession().Value(), binding.remote,
102102
triggerEffectCommand, onSuccess, onFailure);
103103
break;
@@ -119,8 +119,8 @@ void ProcessIdentifyGroupBindingCommand(BindingCommandData * data, const EmberBi
119119
break;
120120

121121
case Clusters::Identify::Commands::TriggerEffect::Id:
122-
triggerEffectCommand.effectIdentifier = static_cast<EmberAfIdentifyEffectIdentifier>(data->args[0]);
123-
triggerEffectCommand.effectVariant = static_cast<EmberAfIdentifyEffectVariant>(data->args[1]);
122+
triggerEffectCommand.effectIdentifier = static_cast<Clusters::Identify::EffectIdentifierEnum>(data->args[0]);
123+
triggerEffectCommand.effectVariant = static_cast<Clusters::Identify::EffectVariantEnum>(data->args[1]);
124124
Controller::InvokeGroupCommandRequest(&exchangeMgr, binding.fabricIndex, binding.groupId, triggerEffectCommand);
125125
break;
126126
}

‎examples/all-clusters-app/cc13x2x7_26x2x7/main/ClusterManager.cpp‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#endif
3030

3131
using namespace ::chip;
32+
using namespace ::chip::app;
3233
using namespace ::chip::Inet;
3334
using namespace ::chip::System;
3435
using namespace ::chip::DeviceLayer;
@@ -45,17 +46,17 @@ void OnIdentifyTriggerEffect(Identify * identify)
4546
{
4647
switch (identify->mCurrentEffectIdentifier)
4748
{
48-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK:
49-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK");
49+
case Clusters::Identify::EffectIdentifierEnum::kBlink:
50+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kBlink");
5051
break;
51-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE:
52-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE");
52+
case Clusters::Identify::EffectIdentifierEnum::kBreathe:
53+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kBreathe");
5354
break;
54-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY:
55-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY");
55+
case Clusters::Identify::EffectIdentifierEnum::kOkay:
56+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kOkay");
5657
break;
57-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE:
58-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE");
58+
case Clusters::Identify::EffectIdentifierEnum::kChannelChange:
59+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kChannelChange");
5960
break;
6061
default:
6162
PLAT_LOG("No identifier effect");
@@ -68,15 +69,15 @@ Identify gIdentify0 = {
6869
chip::EndpointId{ 0 },
6970
[](Identify *) { PLAT_LOG("onIdentifyStart"); },
7071
[](Identify *) { PLAT_LOG("onIdentifyStop"); },
71-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
72+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
7273
OnIdentifyTriggerEffect,
7374
};
7475

7576
Identify gIdentify1 = {
7677
chip::EndpointId{ 1 },
7778
[](Identify *) { PLAT_LOG("onIdentifyStart"); },
7879
[](Identify *) { PLAT_LOG("onIdentifyStop"); },
79-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
80+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
8081
OnIdentifyTriggerEffect,
8182
};
8283

‎examples/all-clusters-app/cc13x4_26x4/main/ClusterManager.cpp‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#endif
2929

3030
using namespace ::chip;
31+
using namespace ::chip::app;
3132
using namespace ::chip::Inet;
3233
using namespace ::chip::System;
3334
using namespace ::chip::DeviceLayer;
@@ -44,17 +45,17 @@ void OnIdentifyTriggerEffect(Identify * identify)
4445
{
4546
switch (identify->mCurrentEffectIdentifier)
4647
{
47-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK:
48-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK");
48+
case Clusters::Identify::EffectIdentifierEnum::kBlink:
49+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kBlink");
4950
break;
50-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE:
51-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE");
51+
case Clusters::Identify::EffectIdentifierEnum::kBreathe:
52+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kBreathe");
5253
break;
53-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY:
54-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY");
54+
case Clusters::Identify::EffectIdentifierEnum::kOkay:
55+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kOkay");
5556
break;
56-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE:
57-
PLAT_LOG("EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE");
57+
case Clusters::Identify::EffectIdentifierEnum::kChannelChange:
58+
PLAT_LOG("Clusters::Identify::EffectIdentifierEnum::kChannelChange");
5859
break;
5960
default:
6061
PLAT_LOG("No identifier effect");
@@ -67,15 +68,15 @@ Identify gIdentify0 = {
6768
chip::EndpointId{ 0 },
6869
[](Identify *) { PLAT_LOG("onIdentifyStart"); },
6970
[](Identify *) { PLAT_LOG("onIdentifyStop"); },
70-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
71+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
7172
OnIdentifyTriggerEffect,
7273
};
7374

7475
Identify gIdentify1 = {
7576
chip::EndpointId{ 1 },
7677
[](Identify *) { PLAT_LOG("onIdentifyStart"); },
7778
[](Identify *) { PLAT_LOG("onIdentifyStop"); },
78-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
79+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
7980
OnIdentifyTriggerEffect,
8081
};
8182

‎examples/all-clusters-app/esp32/main/DeviceCallbacks.cpp‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,18 @@ void OnIdentifyTriggerEffect(Identify * identify)
5454
{
5555
switch (identify->mCurrentEffectIdentifier)
5656
{
57-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK:
57+
case Clusters::Identify::EffectIdentifierEnum::kBlink:
5858
statusLED1.Blink(kIdentifyTimerDelayMS * 2);
59-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK");
59+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kBlink");
6060
break;
61-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE:
62-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE");
61+
case Clusters::Identify::EffectIdentifierEnum::kBreathe:
62+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kBreathe");
6363
break;
64-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY:
65-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY");
64+
case Clusters::Identify::EffectIdentifierEnum::kOkay:
65+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kOkay");
6666
break;
67-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE:
68-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE");
67+
case Clusters::Identify::EffectIdentifierEnum::kChannelChange:
68+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kChannelChange");
6969
break;
7070
default:
7171
ChipLogProgress(Zcl, "No identifier effect");
@@ -78,15 +78,15 @@ Identify gIdentify0 = {
7878
chip::EndpointId{ 0 },
7979
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStart"); },
8080
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStop"); },
81-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
81+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
8282
OnIdentifyTriggerEffect,
8383
};
8484

8585
Identify gIdentify1 = {
8686
chip::EndpointId{ 1 },
8787
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStart"); },
8888
[](Identify *) { ChipLogProgress(Zcl, "onIdentifyStop"); },
89-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED,
89+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
9090
OnIdentifyTriggerEffect,
9191
};
9292

‎examples/all-clusters-app/linux/main-common.cpp‎

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,17 @@ void OnTriggerEffect(::Identify * identify)
7777
{
7878
switch (identify->mCurrentEffectIdentifier)
7979
{
80-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK:
81-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK");
80+
case Clusters::Identify::EffectIdentifierEnum::kBlink:
81+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kBlink");
8282
break;
83-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE:
84-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE");
83+
case Clusters::Identify::EffectIdentifierEnum::kBreathe:
84+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kBreathe");
8585
break;
86-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY:
87-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY");
86+
case Clusters::Identify::EffectIdentifierEnum::kOkay:
87+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kOkay");
8888
break;
89-
case EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE:
90-
ChipLogProgress(Zcl, "EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE");
89+
case Clusters::Identify::EffectIdentifierEnum::kChannelChange:
90+
ChipLogProgress(Zcl, "Clusters::Identify::EffectIdentifierEnum::kChannelChange");
9191
break;
9292
default:
9393
ChipLogProgress(Zcl, "No identifier effect");
@@ -96,11 +96,13 @@ void OnTriggerEffect(::Identify * identify)
9696
}
9797

9898
static Identify gIdentify0 = {
99-
chip::EndpointId{ 0 }, OnIdentifyStart, OnIdentifyStop, EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED, OnTriggerEffect,
99+
chip::EndpointId{ 0 }, OnIdentifyStart, OnIdentifyStop, Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
100+
OnTriggerEffect,
100101
};
101102

102103
static Identify gIdentify1 = {
103-
chip::EndpointId{ 1 }, OnIdentifyStart, OnIdentifyStop, EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED, OnTriggerEffect,
104+
chip::EndpointId{ 1 }, OnIdentifyStart, OnIdentifyStop, Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator,
105+
OnTriggerEffect,
104106
};
105107

106108
// Network commissioning

‎examples/all-clusters-app/nrfconnect/main/AppTask.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ k_timer sFunctionTimer;
7171
chip::DeviceLayer::DeviceInfoProviderImpl gExampleDeviceInfoProvider;
7272

7373
Identify sIdentify = { kIdentifyEndpointId, AppTask::IdentifyStartHandler, AppTask::IdentifyStopHandler,
74-
EMBER_ZCL_IDENTIFY_IDENTIFY_TYPE_VISIBLE_LED };
74+
Clusters::Identify::IdentifyTypeEnum::kVisibleIndicator };
7575

7676
LEDWidget sStatusLED;
7777
LEDWidget sIdentifyLED;

‎examples/all-clusters-app/telink/Readme.md‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,14 @@ following states:
8383
Identify command of the Identify cluster is received. The command's argument can
8484
be used to specify the the effect. It is able to be in following effects:
8585
86-
| Effect | Description |
87-
| :------------------------------ | :------------------------------------------------------------------- |
88-
| Blinks (200 ms on/200 ms off) | Blink (EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BLINK) |
89-
| Breathe (during 1000 ms) | Breathe (EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_BREATHE) |
90-
| Blinks (50 ms on/950 ms off) | Okay (EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_OKAY) |
91-
| Blinks (1000 ms on/1000 ms off) | Channel Change (EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_CHANNEL_CHANGE) |
92-
| Blinks (950 ms on/50 ms off) | Finish (EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_FINISH_EFFECT) |
93-
| LED off | Stop (EMBER_ZCL_IDENTIFY_EFFECT_IDENTIFIER_STOP_EFFECT) |
86+
| Effect | Description |
87+
| :------------------------------ | :--------------------------------------------------------------------------- |
88+
| Blinks (200 ms on/200 ms off) | Blink (`Clusters::Identify::EffectIdentifierEnum::kBlink`) |
89+
| Breathe (during 1000 ms) | Breathe (`Clusters::Identify::EffectIdentifierEnum::kBreathe`) |
90+
| Blinks (50 ms on/950 ms off) | Okay (`Clusters::Identify::EffectIdentifierEnum::kOkay`) |
91+
| Blinks (1000 ms on/1000 ms off) | Channel Change ( `Clusters::Identify::EffectIdentifierEnum::kChannelChange`) |
92+
| Blinks (950 ms on/50 ms off) | Finish ( `Clusters::Identify::EffectIdentifierEnum::kFinishEffect`) |
93+
| LED off | Stop (`Clusters::Identify::EffectIdentifierEnum::kStopEffect`) |
9494
9595
### CHIP tool commands
9696

0 commit comments

Comments
 (0)