Fix log level in examples#2902
Merged
janiversen merged 2 commits intoMar 12, 2026
Merged
Conversation
janiversen
requested changes
Mar 12, 2026
Collaborator
janiversen
left a comment
There was a problem hiding this comment.
please see comment on the corresponding issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets
logging.basicConfig()in several example applications so that it respects the user's selection at the CLI (see #2901).Background
In order for Python to respect the log level that is set,
logging.basicConfig()must be called.If this is not done, then the first calls to logging functions will:
basicConfig()internally (see logging.debug())The
lastResorthandler defaults to a log level ofWARNING, which I believe is why most log statements do not appear.Examples
Info level
Setup:
For the server:
For the client:
Note that:
__file__has an impactINFO-level logs fromserver_async.pynow appearINFO-level logs fromclient_async.pynow appearDebug level
Setup:
For the server
For the client:
Open Questions
Should examples call
logging.getLogger(__name__)instead oflogging.getLogger(__file__)?This is recommended by the docs and gives log messages that are more brief.