Dont's expose has_custom_setattr

Author: hynek

src/attr/_make.py

@@ -137,7 +137,6 @@ class ClassProps(NamedTuple):
     match_args: bool
     str: bool
     getstate_setstate: bool
-    has_custom_setattr: bool
     on_setattr: Callable[[str, Any], Any]
     field_transformer: Callable[[Attribute], Attribute]
 
@@ -703,6 +702,7 @@ def __init__(
         these,
         auto_attribs: bool,
         props: ClassProps,
+        has_custom_setattr: bool,
     ):
         attrs, base_attrs, base_map = _transform_attrs(
             cls,
@@ -737,7 +737,7 @@ def __init__(
         self._is_exc = props.is_exception
         self._on_setattr = props.on_setattr
 
-        self._has_custom_setattr = props.has_custom_setattr
+        self._has_custom_setattr = has_custom_setattr
         self._wrote_own_setattr = False
 
         self._cls_dict["__attrs_attrs__"] = self._attrs
@@ -1536,13 +1536,16 @@ def wrap(cls):
                 ("__getstate__", "__setstate__"),
                 default=slots,
             ),
-            has_custom_setattr=has_own_setattr,
             on_setattr=on_setattr,
             field_transformer=field_transformer,
         )
 
         builder = _ClassBuilder(
-            cls, these, auto_attribs=auto_attribs, props=props
+            cls,
+            these,
+            auto_attribs=auto_attribs,
+            props=props,
+            has_custom_setattr=has_own_setattr,
         )
 
         if props.repr is True:

tests/test_make.py

@@ -549,7 +549,6 @@ class C:
                 cache_hash=True,
                 str=True,
                 getstate_setstate=True,
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             )
@@ -584,7 +583,6 @@ class CDef:
                 cache_hash=False,
                 str=False,
                 getstate_setstate=False,
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             )
@@ -2031,10 +2029,10 @@ class C:
                 cache_hash=False,
                 str=False,
                 getstate_setstate=True,
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             ),
+            has_custom_setattr=False,
         )
 
         assert "<_ClassBuilder(cls=C)>" == repr(b)
@@ -2068,10 +2066,10 @@ class C:
                 cache_hash=False,
                 str=False,
                 getstate_setstate=True,
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             ),
+            has_custom_setattr=False,
         )
 
         cls = (
@@ -2171,10 +2169,10 @@ def our_hasattr(obj, name, /) -> bool:
                 cache_hash=False,
                 str=False,
                 getstate_setstate=True,
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             ),
+            has_custom_setattr=False,
         )
 
         def fake_meth(self):

tests/test_next_gen.py

@@ -493,7 +493,6 @@ class C:
                 cache_hash=True,
                 str=True,
                 getstate_setstate=False,  # because slots=False
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             )
@@ -527,7 +526,6 @@ class C:
                 cache_hash=False,
                 str=False,
                 getstate_setstate=True,
-                has_custom_setattr=False,
                 on_setattr=None,
                 field_transformer=None,
             )