Skip to content

Commit 473b650

Browse files
[mxfp8 training] add TP warning
1 parent 0691f51 commit 473b650

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

torchtitan/components/quantization/mx.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ def __init__(
8484
"torch.compile enablement is required for highest performance of MXFP8 dynamic quantization."
8585
)
8686

87+
if parallel_dims.tp > 1:
88+
logger.warning(
89+
"TP support for MXFP8 linears is still in progress. "
90+
"Any linear layers with TP applied will use default precision, not MXFP8."
91+
)
92+
8793
self.config = config
8894
self.enabled = True
8995
logger.info("MXFP8 MoE training enabled")

torchtitan/models/deepseek_v3/config_registry.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
Float8GroupedMMConverter,
1313
Float8LinearConverter,
1414
)
15+
from torchtitan.components.quantization.mx import MXFP8Converter
1516
from torchtitan.config import (
1617
ActivationCheckpointConfig,
1718
CompileConfig,
@@ -82,9 +83,17 @@ def deepseek_v3_16b() -> Trainer.Config:
8283
seq_len=4096,
8384
steps=1000,
8485
),
86+
model_converters=ModelConvertersContainer.Config(
87+
converters=[
88+
MXFP8Converter.Config(fqns=["moe.shared_experts"]),
89+
],
90+
print_after_conversion=True,
91+
),
8592
parallelism=ParallelismConfig(
8693
pipeline_parallel_schedule="Interleaved1F1B",
87-
expert_parallel_degree=8,
94+
expert_parallel_degree=4,
95+
data_parallel_shard_degree=4,
96+
tensor_parallel_degree=2,
8897
expert_tensor_parallel_degree=1,
8998
),
9099
checkpoint=CheckpointManager.Config(interval=10),

0 commit comments

Comments
 (0)