Skip to content

Commit 8af5459

Browse files
committed
fix NPE as reported in issues/1014
Signed-off-by: ceki <ceki@qos.ch>
1 parent 4f560a0 commit 8af5459

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

logback-core/src/main/java/ch/qos/logback/core/model/processor/DependencyDefinition.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626
*/
2727
public class DependencyDefinition {
2828

29+
// depender depends on dependency (new terminology)
30+
// dependency synonym dependee
31+
// depender synonym dependent
32+
2933
// OLD terminology: dependee (=dependency), dependent(=depender)
3034
//
3135
// NEW terminology: *dependent*: a component of type Model which depends on a *dependency*

logback-core/src/main/java/ch/qos/logback/core/util/VersionUtil.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,11 @@ static public void checkForVersionEquality(Context context, String dependentVers
182182
// the dependent depends on the dependency
183183
addFoundVersionStatus(context, dependentName, dependentVersion);
184184

185+
if(dependencyVersion == null) {
186+
String nullDependencyVersion = String.format("Failed to find version for %s.", dependencyName);
187+
context.getStatusManager().add(new WarnStatus(nullDependencyVersion, context));
188+
return;
189+
}
185190
if (dependentVersion.equals(NA) || !dependentVersion.equals(dependencyVersion)) {
186191
addFoundVersionStatus(context, dependencyName, dependencyVersion);
187192
String discrepancyMsg = String.format("Versions of %s and %s are different!", dependencyName, dependentName);

0 commit comments

Comments
 (0)