Skip to content

Commit d9e7037

Browse files
authored
Merge pull request #625 from amatsuda/kwargs
Fixes for Ruby 2.7 keyword arguments warnings
2 parents cbf3b82 + 013c681 commit d9e7037

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

lib/sprockets/base.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ def file_digest(path)
7575
end
7676

7777
# Find asset by logical path or expanded path.
78-
def find_asset(*args)
79-
uri, _ = resolve(*args)
78+
def find_asset(*args, **options)
79+
uri, _ = resolve(*args, **options)
8080
if uri
8181
load(uri)
8282
end

lib/sprockets/environment.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ def cached
2727
end
2828
alias_method :index, :cached
2929

30-
def find_asset(*args)
31-
cached.find_asset(*args)
30+
def find_asset(*args, **options)
31+
cached.find_asset(*args, **options)
3232
end
3333

3434
def find_asset!(*args)

test/test_asset.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ def setup
332332
end
333333

334334
def asset(logical_path, options = {})
335-
@env.find_asset(logical_path, {pipeline: @pipeline}.merge(options))
335+
@env.find_asset(logical_path, **{pipeline: @pipeline}.merge(options))
336336
end
337337
end
338338

@@ -403,7 +403,7 @@ def setup
403403
end
404404

405405
def asset(logical_path, options = {})
406-
@env.find_asset(logical_path, {pipeline: @pipeline}.merge(options))
406+
@env.find_asset(logical_path, **{pipeline: @pipeline}.merge(options))
407407
end
408408
end
409409

@@ -1110,7 +1110,7 @@ def setup
11101110
end
11111111

11121112
def asset(logical_path, options = {})
1113-
@env.find_asset(logical_path, {pipeline: @pipeline}.merge(options))
1113+
@env.find_asset(logical_path, **{pipeline: @pipeline}.merge(options))
11141114
end
11151115

11161116
def read(logical_path)
@@ -1245,7 +1245,7 @@ def logical_path(path, options = {})
12451245
filename = fixture_path("paths/#{path}")
12461246
assert File.exist?(filename), "#{filename} does not exist"
12471247
silence_warnings do
1248-
assert asset = @env.find_asset(filename, options), "couldn't find asset: #{filename}"
1248+
assert asset = @env.find_asset(filename, **options), "couldn't find asset: #{filename}"
12491249
asset.logical_path
12501250
end
12511251
end
@@ -1308,7 +1308,7 @@ def content_type(path, options = {})
13081308
filename = fixture_path("paths/#{path}")
13091309
assert File.exist?(filename), "#{filename} does not exist"
13101310
silence_warnings do
1311-
assert asset = @env.find_asset(filename, options), "couldn't find asset: #{filename}"
1311+
assert asset = @env.find_asset(filename, **options), "couldn't find asset: #{filename}"
13121312
asset.content_type
13131313
end
13141314
end

test/test_resolve.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,15 +255,15 @@ def setup
255255
@env.append_path(random_path)
256256

257257
error = assert_raises(Sprockets::FileNotFound) do
258-
uri, _ = @env.resolve!("thisfiledoesnotexistandshouldraiseerrors", {})
258+
uri, _ = @env.resolve!("thisfiledoesnotexistandshouldraiseerrors", **{})
259259
uri
260260
end
261261

262262
assert_match(/#{ random_path }/, error.message)
263263
end
264264

265-
def resolve(path, options = {})
266-
uri, _ = @env.resolve(path, options)
265+
def resolve(path, **options)
266+
uri, _ = @env.resolve(path, **options)
267267
uri
268268
end
269269
end

0 commit comments

Comments
 (0)