Skip to content

Warn if there are multiple manifest files#560

Merged
schneems merged 3 commits into
rails:masterfrom
michaelglass:michaelglass/warning-on-multiple-manifests
May 22, 2019
Merged

Warn if there are multiple manifest files#560
schneems merged 3 commits into
rails:masterfrom
michaelglass:michaelglass/warning-on-multiple-manifests

Conversation

@michaelglass

Copy link
Copy Markdown
Contributor

fixes parts of #559

When, somehow, there are two potential manifest files, raise a warning before picking the first one.

@rails-bot

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@schneems

Copy link
Copy Markdown
Member

I'm good with this warning. Looks like you need a rebase. Can we also add the name of the manifest file that is being selected to the warning?

@michaelglass

Copy link
Copy Markdown
Contributor Author

@schneems

@schneems schneems merged commit 358f83f into rails:master May 22, 2019
@envygeeks

Copy link
Copy Markdown
Contributor

Is this meant to be backwards compatible or a breaking change? In that I’m getting bug reports about argument errors, for jekyll-assets manifest, but it seems that this pull defaults the second argument?

@schneems

schneems commented May 25, 2019 via email

Copy link
Copy Markdown
Member

@envygeeks

Copy link
Copy Markdown
Contributor

When I’m at my laptop in the morning I’ll tag you in the issue I got and put up an example app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants