Merge pull request #3024 from maoxor/fix/live-inspect-iscoroutinefunction

Fix DeprecationWarning from asyncio.iscoroutinefunction in AsyncWebSocket.listen

Author: ValueRaider

tests/test_live.py

@@ -1,7 +1,10 @@
+import asyncio
+import json
 import unittest
+import warnings
 from unittest.mock import Mock
 
-from yfinance.live import BaseWebSocket
+from yfinance.live import AsyncWebSocket, BaseWebSocket
 
 
 class TestWebSocket(unittest.TestCase):
@@ -28,3 +31,50 @@ def test_decode_message_invalid(self):
         assert "error" in decoded
         assert "raw_base64" in decoded
         self.assertEqual(base64_message, decoded["raw_base64"])
+
+
+class _FakeAsyncConnection:
+    def __init__(self, messages):
+        self._messages = messages
+        self.closed = False
+
+    async def __aiter__(self):
+        for message in self._messages:
+            yield message
+        raise asyncio.CancelledError
+
+    async def close(self):
+        self.closed = True
+
+
+class TestAsyncWebSocketListen(unittest.IsolatedAsyncioTestCase):
+    message = ("CgdCVEMtVVNEFYoMuUcYwLCVgIplIgNVU0QqA0NDQzApOAFFPWrEP0iAgOrxvANVx/25R12csrRHZYD8skR9/"
+               "7i0R7ABgIDq8bwD2AEE4AGAgOrxvAPoAYCA6vG8A/IBA0JUQ4ECAAAAwPrjckGJAgAA2P5ZT3tC")
+
+    async def _listen(self, handler):
+        ws = AsyncWebSocket(verbose=False)
+        ws._ws = _FakeAsyncConnection([json.dumps({"message": self.message})])
+        with warnings.catch_warnings():
+            # asyncio.iscoroutinefunction is deprecated since Python 3.14.
+            warnings.simplefilter("error", DeprecationWarning)
+            await ws.listen(handler)
+        self.assertTrue(ws._ws.closed)
+
+    async def test_listen_awaits_async_handler(self):
+        received = []
+
+        async def handler(message):
+            received.append(message)
+
+        await self._listen(handler)
+        self.assertEqual(["BTC-USD"], [m["id"] for m in received])
+
+    async def test_listen_calls_sync_handler(self):
+        received = []
+
+        def handler(message):
+            received.append(message)
+
+        await self._listen(handler)
+        self.assertEqual(["BTC-USD"], [m["id"] for m in received])
+

yfinance/live.py

@@ -1,5 +1,6 @@
 import asyncio
 import base64
+import inspect
 import json
 from typing import List, Optional, Callable, Union
 
@@ -164,7 +165,7 @@ async def listen(self, message_handler=None):
 
                     if self._message_handler:
                         try:
-                            if asyncio.iscoroutinefunction(self._message_handler):
+                            if inspect.iscoroutinefunction(self._message_handler):
                                 await self._message_handler(decoded_message)
                             else:
                                 self._message_handler(decoded_message)