Test creating invalid socket address and improve test coverage

Author: clue

src/TcpConnector.php

@@ -25,9 +25,9 @@ public function create($ip, $port)
 
         $url = $this->getSocketUrl($ip, $port);
 
-        $socket = stream_socket_client($url, $errno, $errstr, 0, STREAM_CLIENT_CONNECT | STREAM_CLIENT_ASYNC_CONNECT);
+        $socket = @stream_socket_client($url, $errno, $errstr, 0, STREAM_CLIENT_CONNECT | STREAM_CLIENT_ASYNC_CONNECT);
 
-        if (!$socket) {
+        if (false === $socket) {
             return Promise\reject(new \RuntimeException(
                 sprintf("connection to %s:%d failed: %s", $ip, $port, $errstr),
                 $errno

tests/TcpConnectorTest.php

@@ -95,4 +95,16 @@ public function connectionToHostnameShouldFailImmediately()
             $this->expectCallableOnce()
         );
     }
+
+    /** @test */
+    public function connectionToInvalidAddressShouldFailImmediately()
+    {
+        $loop = $this->getMock('React\EventLoop\LoopInterface');
+
+        $connector = new TcpConnector($loop);
+        $connector->create('255.255.255.255', 12345678)->then(
+            $this->expectCallableNever(),
+            $this->expectCallableOnce()
+        );
+    }
 }