Use done() when the goal is not transformation

Author: arnaud-lb

src/Query/RecordCache.php

@@ -59,7 +59,7 @@ function ($e) {
                     return new RecordBag();
                 }
             )
-            ->then(function ($recordBag) use ($id, $currentTime, $record, $cache) {
+            ->done(function ($recordBag) use ($id, $currentTime, $record, $cache) {
                 $recordBag->set($currentTime, $record);
                 $cache->set($id, serialize($recordBag));
             });

src/Query/RetryExecutor.php

@@ -45,6 +45,6 @@ public function tryQuery($nameserver, Query $query, $retries, $deferred)
 
         $this->executor
             ->query($nameserver, $query)
-            ->then(array($deferred, 'resolve'), $errorback);
+            ->done(array($deferred, 'resolve'), $errorback);
     }
 }

tests/Query/RetryExecutorTest.php

@@ -124,6 +124,30 @@ public function queryShouldForwardNonTimeoutErrors()
         $retryExecutor->query('8.8.8.8', $query)->then($callback, $errorback);
     }
 
+    /**
+     * @test
+     * @expectedException Exception
+     * @expectedExceptionMessage query failed
+     */
+    public function queryDoesNotHideErrors()
+    {
+        $executor = $this->createExecutorMock();
+        $executor
+            ->expects($this->once())
+            ->method('query')
+            ->with('8.8.8.8', $this->isInstanceOf('React\Dns\Query\Query'))
+            ->will($this->returnCallback(function ($domain, $query) {
+                return Promise\reject(new \Exception('query failed'));
+            }));
+
+        $retryExecutor = new RetryExecutor($executor, 2);
+
+        $query = new Query('igor.io', Message::TYPE_A, Message::CLASS_IN, 1345656451);
+        $retryExecutor
+            ->query('8.8.8.8', $query)
+            ->done();
+    }
+
     protected function expectCallableOnce()
     {
         $mock = $this->createCallableMock();
@@ -149,7 +173,7 @@ protected function expectPromiseOnce($return = null)
         $mock = $this->createPromiseMock();
         $mock
             ->expects($this->once())
-            ->method('then')
+            ->method('done')
             ->will($this->returnValue($return));
 
         return $mock;
@@ -167,7 +191,7 @@ protected function createExecutorMock()
 
     protected function createPromiseMock()
     {
-        return $this->getMock('React\Promise\PromiseInterface');
+        return $this->getMock('React\Promise\ExtendedPromiseInterface');
     }
 
     protected function createStandardResponse()