Added tests for the 411 and 413 errors

Author: WyriHaximus

tests/Middleware/RequestBodyBufferTest.php

@@ -4,7 +4,6 @@
 
 use Psr\Http\Message\ServerRequestInterface;
 use React\Http\Middleware\RequestBodyBuffer;
-use React\Http\Response;
 use React\Http\ServerRequest;
 use React\Tests\Http\TestCase;
 use RingCentral\Psr7\BufferStream;
@@ -36,47 +35,45 @@ function (ServerRequestInterface $request) use (&$exposedRequest) {
         $this->assertSame($body, $exposedRequest->getBody()->getContents());
     }
 
-    public function testToLargeBody()
+    public function test411Error()
     {
-        $size = $this->iniMaxPostSize() + 1;
-        $stream = new BufferStream($size);
-        $stream->write(str_repeat('x', $size));
+        $body = $this->getMockBuilder('Psr\Http\Message\StreamInterface')->getMock();
+        $body->expects($this->once())->method('getSize')->willReturn(null);
+
         $serverRequest = new ServerRequest(
             'GET',
             'https://example.com/',
             array(),
-            $stream
+            $body
         );
 
-        $shouldNotHaveBeenCalled = false;
         $buffer = new RequestBodyBuffer();
         $response = $buffer(
             $serverRequest,
-            function () use (&$shouldNotHaveBeenCalled) {
-                $shouldNotHaveBeenCalled = true;
-            }
+            function () {}
         );
 
-        $this->assertFalse($shouldNotHaveBeenCalled);
-        $this->assertInstanceOf('React\Http\Response', $response);
-        $this->assertSame(413, $response->getStatusCode());
-        $this->assertSame('Request body exceeds allowed limit', (string)$response->getBody());
+        $this->assertSame(411, $response->getStatusCode());
     }
 
-    private function iniMaxPostSize()
+    public function test413Error()
     {
-        $size = ini_get('post_max_size');
-        $suffix = strtoupper(substr($size, -1));
-        if ($suffix === 'K') {
-            return substr($size, 0, -1) * 1024;
-        }
-        if ($suffix === 'M') {
-            return substr($size, 0, -1) * 1024 * 1024;
-        }
-        if ($suffix === 'G') {
-            return substr($size, 0, -1) * 1024  * 1024 * 1024;
-        }
+        $stream = new BufferStream(2);
+        $stream->write('aa');
 
-        return $size;
+        $serverRequest = new ServerRequest(
+            'GET',
+            'https://example.com/',
+            array(),
+            $stream
+        );
+
+        $buffer = new RequestBodyBuffer(1);
+        $response = $buffer(
+            $serverRequest,
+            function () {}
+        );
+
+        $this->assertSame(413, $response->getStatusCode());
     }
 }