snc: fix a panic when not using spot instance #601
Merged
Conversation
on the snc the env variable for checking if the bundle should be started in self sufficint mode was changed to CRC_SELF_SUFFICIENT in crc-org/snc#1153
if case of non-spot the allocationData struct has a nil SpotPrice and trying to access it without checking for nil results in a panic
anjannath
force-pushed
the
misc-fixes
branch
from
9300f0d to
7239020
Compare
adrianriobo
approved these changes
Sep 24, 2025
Collaborator
adrianriobo
left a comment
adrianriobo
left a comment
There was a problem hiding this comment.
LGTM
I totally missed it on SNC ...I fixed on kind but forgot it here 🤯
Collaborator
|
@anjannath need to sign the commit |
Collaborator
|
@anjannath NVM I changed some setting and it was too strcit |
Collaborator
Author
ahh sorry, i will add GPG key to my github account and have signed commits from now on, thanks for the exception this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.