Skip to content

Commit 64d872c

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Add support for configuring coordination/backend_url"
2 parents 866208c + fade72d commit 64d872c

4 files changed

Lines changed: 33 additions & 5 deletions

File tree

manifests/agent/central.pp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,16 @@
1313
# (optional) ensure state for package.
1414
# Defaults to 'present'
1515
#
16+
# [*coordination_url*]
17+
# (optional) The url to use for distributed group membership coordination.
18+
# Defaults to undef.
19+
#
1620

1721
class ceilometer::agent::central (
1822
$manage_service = true,
1923
$enabled = true,
2024
$package_ensure = 'present',
25+
$coordination_url = undef,
2126
) {
2227

2328
include ceilometer::params
@@ -47,4 +52,8 @@
4752
hasrestart => true,
4853
}
4954

55+
if $coordination_url {
56+
ensure_resource('ceilometer_config', 'coordination/backend_url',
57+
{'value' => $coordination_url})
58+
}
5059
}

manifests/alarm/evaluator.pp

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,18 @@
2525
# (optional) Record alarm change events
2626
# Defaults to true.
2727
#
28+
# [*coordination_url*]
29+
# (optional) The url to use for distributed group membership coordination.
30+
# Defaults to undef.
31+
#
2832
class ceilometer::alarm::evaluator (
2933
$manage_service = true,
3034
$enabled = true,
3135
$evaluation_interval = 60,
3236
$evaluation_service = 'ceilometer.alarm.service.SingletonAlarmService',
3337
$partition_rpc_topic = 'alarm_partition_coordination',
3438
$record_history = true,
39+
$coordination_url = undef,
3540
) {
3641

3742
include ceilometer::params
@@ -67,5 +72,10 @@
6772
'alarm/evaluation_service' : value => $evaluation_service;
6873
'alarm/partition_rpc_topic' : value => $partition_rpc_topic;
6974
'alarm/record_history' : value => $record_history;
70-
}
75+
}
76+
77+
if $coordination_url {
78+
ensure_resource('ceilometer_config', 'coordination/backend_url',
79+
{'value' => $coordination_url})
80+
}
7181
}

spec/classes/ceilometer_agent_central_spec.rb

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
end
88

99
let :params do
10-
{ :enabled => true,
11-
:manage_service => true,
12-
:package_ensure => 'latest' }
10+
{ :enabled => true,
11+
:manage_service => true,
12+
:package_ensure => 'latest',
13+
:coordination_url => 'redis://localhost:6379'
14+
}
1315
end
1416

1517
shared_examples_for 'ceilometer-agent-central' do
@@ -48,6 +50,10 @@
4850
end
4951
end
5052

53+
it 'configures central agent' do
54+
should contain_ceilometer_config('coordination/backend_url').with_value( params[:coordination_url] )
55+
end
56+
5157
context 'with disabled service managing' do
5258
before do
5359
params.merge!({

spec/classes/ceilometer_alarm_evaluator_spec.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,22 @@
3838
should contain_ceilometer_config('alarm/evaluation_service').with_value( params[:evaluation_service] )
3939
should contain_ceilometer_config('alarm/partition_rpc_topic').with_value( params[:partition_rpc_topic] )
4040
should contain_ceilometer_config('alarm/record_history').with_value( params[:record_history] )
41+
should_not contain_ceilometer_config('coordination/backend_url')
4142
end
4243

4344
context 'when overriding parameters' do
4445
before do
4546
params.merge!(:evaluation_interval => 80,
4647
:partition_rpc_topic => 'alarm_partition_coordination',
4748
:record_history => false,
48-
:evaluation_service => 'ceilometer.alarm.service.SingletonTestAlarmService')
49+
:evaluation_service => 'ceilometer.alarm.service.SingletonTestAlarmService',
50+
:coordination_url => 'redis://localhost:6379')
4951
end
5052
it { should contain_ceilometer_config('alarm/evaluation_interval').with_value(params[:evaluation_interval]) }
5153
it { should contain_ceilometer_config('alarm/evaluation_service').with_value(params[:evaluation_service]) }
5254
it { should contain_ceilometer_config('alarm/record_history').with_value(params[:record_history]) }
5355
it { should contain_ceilometer_config('alarm/partition_rpc_topic').with_value(params[:partition_rpc_topic]) }
56+
it { should contain_ceilometer_config('coordination/backend_url').with_value( params[:coordination_url]) }
5457
end
5558

5659
context 'when override the evaluation interval with a non numeric value' do

0 commit comments

Comments
 (0)