Pin tests to rspec < 2.99

Pin to rspec < 2.99 until rspec-puppet officially supports rspec 3.x.
This is to avoid warnings due to deprecated matchers in the
rspec-puppet gem.

This patch also reverts the change of be_false to be_falsey that was
temporarily required for rspec 3 compability.

Partial-Bug: #1326034
Change-Id: I1f7a754cf285c598169059e757c1a905762e2ce0

Author: claytono

Gemfile

@@ -7,6 +7,7 @@ group :development, :test do
   gem 'puppet-lint', '~> 0.3.2'
   gem 'rake', '10.1.1'
   gem 'webmock'
+  gem 'rspec', '< 2.99'
 end
 
 if puppetversion = ENV['PUPPET_GEM_VERSION']

spec/unit/provider/nova_admin_tenant_id_setter/neutron_spec.rb

@@ -74,7 +74,7 @@ def create
         it 'should create a resource' do
             resource = Puppet::Type::Nova_admin_tenant_id_setter.new(params)
             provider = provider_class.new(resource)
-            expect(provider.exists?).to be_falsey
+            expect(provider.exists?).to be_false
             expect(provider.create).to be_nil
         end
     end
@@ -98,7 +98,7 @@ def create
         it 'should receive an api error' do
             resource = Puppet::Type::Nova_admin_tenant_id_setter.new(params)
             provider = provider_class.new(resource)
-            expect(provider.exists?).to be_falsey
+            expect(provider.exists?).to be_false
             expect { provider.create }.to raise_error KeystoneAPIError, /Unable to find matching tenant/
         end
     end
@@ -123,7 +123,7 @@ def create
         it 'should receive an api error' do
             resource = Puppet::Type::Nova_admin_tenant_id_setter.new(params)
             provider = provider_class.new(resource)
-            expect(provider.exists?).to be_falsey
+            expect(provider.exists?).to be_false
             expect { provider.create }.to raise_error KeystoneAPIError, /Found multiple matches for tenant name/
         end
     end
@@ -140,7 +140,7 @@ def create
         it 'should receive an authentication error' do
             resource = Puppet::Type::Nova_admin_tenant_id_setter.new(params)
             provider = provider_class.new(resource)
-            expect(provider.exists?).to be_falsey
+            expect(provider.exists?).to be_false
             expect { provider.create }.to raise_error KeystoneAPIError
         end
     end
@@ -154,7 +154,7 @@ def create
         it 'should receive a connection error' do
             resource = Puppet::Type::Nova_admin_tenant_id_setter.new(params)
             provider = provider_class.new(resource)
-            expect(provider.exists?).to be_falsey
+            expect(provider.exists?).to be_false
             expect { provider.create }.to raise_error KeystoneConnectionError
         end
     end
@@ -168,7 +168,7 @@ def create
         it 'should receive a connection error' do
             resource = Puppet::Type::Nova_admin_tenant_id_setter.new(params)
             provider = provider_class.new(resource)
-            expect(provider.exists?).to be_falsey
+            expect(provider.exists?).to be_false
             expect { provider.create }.to raise_error KeystoneConnectionError
         end
     end