Skip to content

fix(latest-version,deployed-version,webhook): respect proxy env vars in requests#699

Merged
JosephKav merged 1 commit intomasterfrom
681-bug-dialtcp-lookup-while-being-behind-a-proxy-only-for-url-type
Dec 9, 2025
Merged

fix(latest-version,deployed-version,webhook): respect proxy env vars in requests#699
JosephKav merged 1 commit intomasterfrom
681-bug-dialtcp-lookup-while-being-behind-a-proxy-only-for-url-type

Conversation

@JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Dec 8, 2025

Clone the default transport, ensuring proxy environment variables are respected (HTTP_PROXY, HTTPS_PROXY and NO_PROXY)

@JosephKav JosephKav added the bug Something isn't working label Dec 8, 2025
@JosephKav JosephKav linked an issue Dec 8, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (8083828) to head (11da8f9).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   98.82%   98.82%   -0.00%     
==========================================
  Files         132      132              
  Lines        8894     8891       -3     
==========================================
- Hits         8789     8786       -3     
  Misses         80       80              
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav marked this pull request as ready for review December 8, 2025 19:39
@JosephKav JosephKav force-pushed the 681-bug-dialtcp-lookup-while-being-behind-a-proxy-only-for-url-type branch from 3407732 to f802af5 Compare December 8, 2025 23:20
…in requests

Clone the default transport, ensuring proxy environment variables are respected
@JosephKav JosephKav force-pushed the 681-bug-dialtcp-lookup-while-being-behind-a-proxy-only-for-url-type branch from f802af5 to 11da8f9 Compare December 9, 2025 13:47
@JosephKav JosephKav merged commit f5e1e14 into master Dec 9, 2025
7 checks passed
@JosephKav JosephKav deleted the 681-bug-dialtcp-lookup-while-being-behind-a-proxy-only-for-url-type branch December 9, 2025 13:54
This was referenced Dec 9, 2025
@JosephKav JosephKav added the go Pull requests that update Go code label Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: dialtcp lookup while being behind a proxy only for URL type

1 participant