Skip to content

feat(core): add context-based graceful shutdown on interrupt signals#766

Merged
JosephKav merged 7 commits intomasterfrom
628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing
Dec 23, 2025
Merged

feat(core): add context-based graceful shutdown on interrupt signals#766
JosephKav merged 7 commits intomasterfrom
628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing

Conversation

@JosephKav
Copy link
Collaborator

Introduces context handling to ensure DB, web server and saving can shutdown safely on user interrupts, or container stop signals.

@JosephKav JosephKav added enhancement New feature or request go Pull requests that update Go code labels Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 90.21526% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.47%. Comparing base (6ea0849) to head (bfea880).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argus/main.go 69.24% 9 Missing and 7 partials ⚠️
config/save.go 86.12% 12 Missing and 3 partials ⚠️
db/init.go 87.31% 6 Missing and 2 partials ⚠️
config/settings.go 80.56% 0 Missing and 7 partials ⚠️
util/verify.go 80.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   98.83%   98.47%   -0.36%     
==========================================
  Files         132      135       +3     
  Lines        8906     9093     +187     
==========================================
+ Hits         8801     8953     +152     
  Misses         80       80              
- Partials       25       60      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Introduces context handling to ensure DB, web server and saving
can shutdown safely on user interrupts, or container stop signals.
@JosephKav JosephKav force-pushed the 628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing branch 2 times, most recently from c5920ca to 14536d8 Compare December 22, 2025 22:04
@JosephKav JosephKav force-pushed the 628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing branch from 3b5909f to b051fde Compare December 22, 2025 22:09
@JosephKav JosephKav force-pushed the 628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing branch from 4efd866 to d6296ee Compare December 23, 2025 17:02
@JosephKav JosephKav force-pushed the 628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing branch from d6296ee to d1831a6 Compare December 23, 2025 19:36
@JosephKav JosephKav merged commit a6ee5a6 into master Dec 23, 2025
6 of 7 checks passed
@JosephKav JosephKav deleted the 628-bug-changes-can-get-lost-when-stopping-container-shortly-after-editing branch December 23, 2025 21:27
@Argus-Bot Argus-Bot mentioned this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Changes can get lost when stopping container shortly after editing

1 participant