Skip to content

fix(command): use candidate version in require.command templates#796

Merged
JosephKav merged 1 commit intomasterfrom
793-bug-an-alert-was-sent-out-when-a-required-command-failed-repeatedly
Jan 12, 2026
Merged

fix(command): use candidate version in require.command templates#796
JosephKav merged 1 commit intomasterfrom
793-bug-an-alert-was-sent-out-when-a-required-command-failed-repeatedly

Conversation

@JosephKav
Copy link
Collaborator

Forgot to give latest_version.require.command checks on new version candidates the version of that candidate, so it was using the previous version.

e.g. latest_version = 1.0.0

query finds 1.0.1

latest_version.require.command = ["echo", "{{ version }}"]
did give 'echo 1.0.0'
now gives 'echo 1.0.1'

@JosephKav JosephKav added bug Something isn't working go Pull requests that update Go code labels Jan 12, 2026
@JosephKav JosephKav linked an issue Jan 12, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.96%. Comparing base (fe13e01) to head (80f8432).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   98.96%   98.96%   +0.01%     
==========================================
  Files         137      137              
  Lines        9222     9224       +2     
==========================================
+ Hits         9126     9128       +2     
  Misses         73       73              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav marked this pull request as ready for review January 12, 2026 17:53
@JosephKav JosephKav merged commit 1e25ecf into master Jan 12, 2026
7 checks passed
@JosephKav JosephKav deleted the 793-bug-an-alert-was-sent-out-when-a-required-command-failed-repeatedly branch January 12, 2026 17:54
@Argus-Bot Argus-Bot mentioned this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: An alert was sent out when a required command failed repeatedly

1 participant