Skip to content

fix(ui): ignore <secret> placeholder in string length validation#797

Merged
JosephKav merged 1 commit intomasterfrom
791-bug-failed-to-parse-teams-notify
Jan 12, 2026
Merged

fix(ui): ignore <secret> placeholder in string length validation#797
JosephKav merged 1 commit intomasterfrom
791-bug-failed-to-parse-teams-notify

Conversation

@JosephKav
Copy link
Collaborator

Teams has validaion for 32-character UUID string lengths (though we just allow alphanumberic of 32-36 to allow for -'s)

When you have a Teams notifier saved, the API will return <secret> as the field value. This validation would then fail as <secret> is less than 32 characters :/. So I've changed the validation to allow <secret>

@JosephKav JosephKav added bug Something isn't working javascript Pull requests that update Javascript code labels Jan 12, 2026
@JosephKav JosephKav linked an issue Jan 12, 2026 that may be closed by this pull request
@JosephKav JosephKav force-pushed the 791-bug-failed-to-parse-teams-notify branch from aa5190a to b69ffc0 Compare January 12, 2026 17:54
@JosephKav JosephKav marked this pull request as ready for review January 12, 2026 17:54
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.96%. Comparing base (1e25ecf) to head (7cc458a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #797   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         137      137           
  Lines        9224     9224           
=======================================
  Hits         9128     9128           
  Misses         73       73           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav force-pushed the 791-bug-failed-to-parse-teams-notify branch from b69ffc0 to 7cc458a Compare January 12, 2026 18:05
@JosephKav JosephKav merged commit 4030861 into master Jan 12, 2026
7 checks passed
@JosephKav JosephKav deleted the 791-bug-failed-to-parse-teams-notify branch January 12, 2026 18:17
@Argus-Bot Argus-Bot mentioned this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Failed to parse Teams notify

1 participant