fix(ui): ignore <secret> placeholder in string length validation#797
Merged
fix(ui): ignore <secret> placeholder in string length validation#797
<secret> placeholder in string length validation#797Conversation
aa5190a to
b69ffc0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 137 137
Lines 9224 9224
=======================================
Hits 9128 9128
Misses 73 73
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b69ffc0 to
7cc458a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teamshas validaion for 32-character UUID string lengths (though we just allow alphanumberic of 32-36 to allow for-'s)When you have a Teams notifier saved, the API will return
<secret>as the field value. This validation would then fail as<secret>is less than 32 characters :/. So I've changed the validation to allow<secret>