Skip to content

Commit 5db0218

Browse files
authored
fix(gerrit): not cloning submodules (#40089)
1 parent ca446fb commit 5db0218

2 files changed

Lines changed: 20 additions & 1 deletion

File tree

lib/modules/platform/gerrit/index.spec.ts

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,23 @@ describe('modules/platform/gerrit/index', () => {
153153
});
154154
});
155155

156+
it('initRepo() - passes cloneSubmodules', async () => {
157+
clientMock.getProjectInfo.mockResolvedValueOnce(projectInfo);
158+
clientMock.findChanges.mockResolvedValueOnce([]);
159+
160+
await gerrit.initRepo({
161+
repository: 'test/repo',
162+
cloneSubmodules: true,
163+
cloneSubmodulesFilter: ['test'],
164+
});
165+
166+
expect(git.initRepo).toHaveBeenCalledExactlyOnceWith({
167+
url: 'https://user:pass@dev.gerrit.com/renovate/a/test%2Frepo',
168+
cloneSubmodules: true,
169+
cloneSubmodulesFilter: ['test'],
170+
});
171+
});
172+
156173
it('initRepo() - abandon rejected changes', async () => {
157174
clientMock.getProjectInfo.mockResolvedValueOnce({
158175
...projectInfo,

lib/modules/platform/gerrit/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ export async function getRepos(): Promise<string[]> {
130130
*/
131131
export async function initRepo({
132132
repository,
133+
cloneSubmodules,
134+
cloneSubmodulesFilter,
133135
gitUrl,
134136
}: RepoParams): Promise<RepoResult> {
135137
logger.debug(`initRepo(${repository}, ${gitUrl})`);
@@ -146,7 +148,7 @@ export async function initRepo({
146148
const baseUrl = defaults.endpoint!;
147149
const url = getGerritRepoUrl(repository, baseUrl);
148150
configureScm(repository, config.gerritUsername!);
149-
await git.initRepo({ url });
151+
await git.initRepo({ url, cloneSubmodules, cloneSubmodulesFilter });
150152

151153
//abandon "open" and "rejected" changes at startup
152154
const rejectedChanges = await client.findChanges(config.repository!, {

0 commit comments

Comments
 (0)