Skip to content

Commit 17f16a8

Browse files
authored
Prep to release 1.8.0-nullsafety.1
Reverts dart-archive/source_span#59 and removes now unnecessary `!`s. This requires a newer sdk than is available on dev, so run tests on be/raw/latest for now. The dart version in flutter should already be compatible with this version.
1 parent cc7c428 commit 17f16a8

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
language: dart
22

33
dart:
4-
- dev
4+
- be/raw/latest
55

66
jobs:
77
include:

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 1.8.0-nullsafety.1
2+
3+
* Fixes a newly recognized unnecessary null check to remove warnings.
4+
15
# 1.8.0-nullsafety
26

37
* Migrate to null safety.

lib/src/highlighter.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,9 +292,7 @@ class Highlighter {
292292
? _primaryColor
293293
: _secondaryColor;
294294
var foundCurrent = false;
295-
for (var tmp in highlightsByColumn) {
296-
// Work around https://github.com/dart-lang/sdk/issues/43136
297-
final highlight = tmp;
295+
for (var highlight in highlightsByColumn) {
298296
final startLine = highlight?.span.start.line;
299297
final endLine = highlight?.span.end.line;
300298
if (current != null && highlight == current) {

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: source_span
2-
version: 1.8.0-nullsafety
2+
version: 1.8.0-nullsafety.1
33

44
description: A library for identifying source spans and locations.
55
homepage: https://github.com/dart-lang/source_span
66

77
environment:
88
# This must remain a tight constraint until nnbd is stable
9-
sdk: '>=2.10.0-0 <2.10.0'
9+
sdk: '>=2.10.0-137.0 <2.10.0'
1010

1111
dependencies:
1212
charcode: '>=1.2.0-nullsafety <1.2.0'

0 commit comments

Comments
 (0)