Skip to content

fix: crashes caused by creating empty components#1003

Merged
lotem merged 7 commits into
rime:masterfrom
jimmy54:fix-create-null-componet-crash
Apr 15, 2025
Merged

fix: crashes caused by creating empty components#1003
lotem merged 7 commits into
rime:masterfrom
jimmy54:fix-create-null-componet-crash

Conversation

@jimmy54
Copy link
Copy Markdown
Contributor

@jimmy54 jimmy54 commented Apr 2, 2025

Pull request

Issue tracker

#1002

Fixes #

Feature

Describe feature of pull request

空对象判断。

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Copy Markdown
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝修復。

經過提醒
也發現
f9411ae#diff-1a92a95c0357705bc3476770234f0037a7b77e3c34e2003d088638712607cc51

兩處 ERROR 之後
返回的結果
不一致
我再改改

@lotem lotem merged commit fa43f3d into rime:master Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants