Attemp to Improve Dict Complile Performance#663
Merged
Conversation
- Replace map with unordered_map for related data structs - Replace boost::lexicast to std::stox This may save 8 % ~ 10 % of the build time of the dictionaries.
WhiredPlanck
force-pushed
the
dict-complile-performance
branch
from
b3d2a5a to
f65ea12
Compare
lotem
reviewed
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes # N/A
Feature
Describe feature of pull request
This PR uses several techniques to try to improve the speed of compiling dictionaries. It may save 8 ~ 10 % of build time of the dictionaries.
Unit test
Manual test
Code Review
Additional Info
Tested schema: rime-ice
Compiler: GCC 13.1.1
OS: Arch Linux x86_64
Before
(Script)Encoder::DfsEncodertakes about 53% of the build time to run before the optimization.After
By speeding up
EntryColletor::TranslateWord,(Script)Encoder::DfsEncodertakes about 45% of the build time to run, about 8% shorter than before.