feat(simplifier): cache opencc#977
Merged
Merged
Conversation
This was referenced Feb 10, 2025
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
@ksqsf 是说弱引用不会被回收么，这就奇怪了，是不是 librime 里还有哪里持有对象？ |
Member
我看错了 |
Closed
Vescrity
added a commit
to Vescrity/librime
that referenced
this pull request
Oct 29, 2025
This reverts commit f9411ae.
Vescrity
added a commit
to Vescrity/librime
that referenced
this pull request
Oct 29, 2025
This reverts commit f9411ae.
Vescrity
added a commit
to Vescrity/librime
that referenced
this pull request
Oct 30, 2025
This reverts commit f9411ae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Feature
之前每创建一个 session，就会重复加载一遍 opencc，造成 session 初始化时卡顿，内存占用也会增加 10 MB 左右。如果有几十个 session，就会额外占用几百 MB 内存。
本 pr 为 opencc 增加了缓存机制，避免重复加载。
Unit test
Manual test
Code Review
Additional Info