fix: do not silently skip errors

rustatian · rustatian · commit b0865e4eb370 · 2026-03-01T10:18:28.000+01:00
Signed-off-by: Valery Piashchynski &lt;piashchynski.valery@gmail.com&gt;
diff --git a/plugin.go b/plugin.go
@@ -140,8 +140,7 @@ func (p *Plugin) Serve() chan error {
 
 func (p *Plugin) checkAndSaveStorage(ctx context.Context, drStr string, name, cfgkey string) error {
 	if _, ok := p.constructors[drStr]; !ok {
-		p.log.Warn("no such constructor was registered", zap.String("requested", drStr), zap.Any("registered", p.constructors))
-		return nil
+		return errors.Errorf("no such constructor was registered: %s, registered: %v", drStr, p.constructors)
 	}
 
 	// use only key for the driver registration, for example, rr-boltdb should be globally available

Original file line number	Diff line number	Diff line change
`@@ -140,8 +140,7 @@ func (p *Plugin) Serve() chan error {`
`140`	`140`
`141`	`141`	`func (p *Plugin) checkAndSaveStorage(ctx context.Context, drStr string, name, cfgkey string) error {`
`142`	`142`	`if _, ok := p.constructors[drStr]; !ok {`
`143`		`- p.log.Warn("no such constructor was registered", zap.String("requested", drStr), zap.Any("registered", p.constructors))`
`144`		`- return nil`
	`143`	`+ return errors.Errorf("no such constructor was registered: %s, registered: %v", drStr, p.constructors)`
`145`	`144`	`}`
`146`	`145`
`147`	`146`	`// use only key for the driver registration, for example, rr-boltdb should be globally available`