Skip to content

Commit cf5cd9d

Browse files
Javier Martinez Canillasdtor
authored andcommitted
Input: qt1070 - add OF device ID table
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:<device>. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. The compatible strings don't have a vendor prefix because that's how it's used currently, and changing this will be a Device Tree ABI break. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 72bf60f commit cf5cd9d

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

drivers/input/keyboard/qt1070.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,18 @@ static const struct i2c_device_id qt1070_id[] = {
274274
};
275275
MODULE_DEVICE_TABLE(i2c, qt1070_id);
276276

277+
#ifdef CONFIG_OF
278+
static const struct of_device_id qt1070_of_match[] = {
279+
{ .compatible = "qt1070", },
280+
{ },
281+
};
282+
MODULE_DEVICE_TABLE(of, qt1070_of_match);
283+
#endif
284+
277285
static struct i2c_driver qt1070_driver = {
278286
.driver = {
279287
.name = "qt1070",
288+
.of_match_table = of_match_ptr(qt1070_of_match),
280289
.pm = &qt1070_pm_ops,
281290
},
282291
.id_table = qt1070_id,

0 commit comments

Comments
 (0)