Minor gas savings

Author: kanewallmann

contracts/contract/deposit/RocketDepositPool.sol

@@ -584,10 +584,11 @@ contract RocketDepositPool is RocketBase, RocketDepositPoolInterface, RocketVaul
         RocketDAOProtocolSettingsDepositInterface rocketDAOProtocolSettingsDeposit = RocketDAOProtocolSettingsDepositInterface(getContractAddress("rocketDAOProtocolSettingsDeposit"));
         require(rocketDAOProtocolSettingsDeposit.getDepositEnabled(), "Deposits into Rocket Pool are currently disabled");
         // Check node operator has sufficient credit
-        uint256 credit = getUint(keccak256(abi.encodePacked("node.deposit.credit.balance", _nodeAddress)));
+        bytes32 creditKey = keccak256(abi.encodePacked("node.deposit.credit.balance", _nodeAddress));
+        uint256 credit = getUint(creditKey);
         require(credit >= _amount, "Amount exceeds credit available");
         // Account for balance changes
-        subUint(keccak256(abi.encodePacked("node.deposit.credit.balance", _nodeAddress)), _amount);
+        subUint(creditKey, _amount);
         // Note: The funds are already stored in RocketVault under RocketDepositPool so no ETH transfer is required
         // Get the node operator's withdrawal address
         RocketNodeManagerInterface rocketNodeManager = RocketNodeManagerInterface(getContractAddress("rocketNodeManager"));

contracts/contract/megapool/RocketMegapoolDelegate.sol

@@ -252,6 +252,8 @@ contract RocketMegapoolDelegate is RocketMegapoolDelegateBase, RocketMegapoolDel
         validator.lastRequestedBond = 0;
         validator.lastRequestedValue = 0;
         validators[_validatorId] = validator;
+        // Delete prestake signature
+        delete prestakeSignatures[_validatorId];
         // Emit event
         emit MegapoolValidatorDequeued(_validatorId, block.timestamp);
     }

contracts/contract/network/RocketNetworkPenalties.sol

@@ -138,7 +138,6 @@ contract RocketNetworkPenalties is RocketBase, RocketNetworkPenaltiesInterface {
         uint256 currentTotal = uint256(currentRunningTotal) - earlierRunningTotal;
         require(currentTotal < maxPenalty, "Max penalty exceeded");
         uint256 currentMaxPenalty = maxPenalty - currentTotal;
-        require(currentMaxPenalty > 0, "Max penalty exceeded");
         // Insert new running total
         rocketNetworkSnapshots.push(penaltyKey, currentRunningTotal + 1);
         // Increment the penalty count on this minipool