Enable reportGeneralTypeIssues in pyright (#305)

Author: nathanjmcdougall

pins/cache.py

@@ -1,9 +1,12 @@
+from __future__ import annotations
+
 import logging
 import os
 import shutil
 import time
 import urllib.parse
 from pathlib import Path
+from typing import Iterator
 
 import humanize
 from fsspec import register_implementation
@@ -20,7 +23,7 @@
 PLACEHOLDER_FILE = "file"
 
 
-def touch_access_time(path, access_time: "float | None" = None, strict=True):
+def touch_access_time(path, access_time: float | None = None, strict=True):
     """Update access time of file.
 
     Returns the new access time.
@@ -220,15 +223,15 @@ class CachePruner:
 
     meta_path = "data.txt"
 
-    def __init__(self, cache_dir: "str | Path"):
+    def __init__(self, cache_dir: str | Path):
         self.cache_dir = Path(cache_dir)
 
-    def versions(self) -> "iter[Path]":
+    def versions(self) -> Iterator[Path]:
         for p_version in self.cache_dir.glob("*/*"):
             if p_version.is_dir() and (p_version / self.meta_path).exists():
                 yield p_version
 
-    def should_prune_version(self, days, path: "str | Path"):
+    def should_prune_version(self, days, path: str | Path):
         path = Path(path)
 
         expiry_time_sec = days * 60 * 60 * 24
@@ -258,7 +261,7 @@ def prune(self, days=30):
         _log.info("Skipping cache deletion")
 
 
-def delete_version(path: "str | Path"):
+def delete_version(path: str | Path):
     path = Path(path)
     shutil.rmtree(str(path.absolute()))
 

pins/constructors.py

@@ -1,6 +1,9 @@
+from __future__ import annotations
+
 import os
 import tempfile
 import warnings
+from typing import Callable
 
 import fsspec
 
@@ -26,10 +29,10 @@ def board(
     protocol: str,
     path: str = "",
     versioned: bool = True,
-    cache: "type[DEFAULT] | None" = DEFAULT,
+    cache: type[DEFAULT] | None = DEFAULT,
     allow_pickle_read=None,
-    storage_options: "dict | None" = None,
-    board_factory: "callable | type[BaseBoard] | None" = None,
+    storage_options: dict | None = None,
+    board_factory: Callable | type[BaseBoard] | None = None,
 ):
     """General function for constructing a pins board.
 

pyproject.toml

@@ -102,7 +102,6 @@ reportArgumentType = false
 reportAssignmentType = false
 reportAttributeAccessIssue = false
 reportCallIssue = false
-reportGeneralTypeIssues = false
 reportIncompatibleMethodOverride = false
 reportIndexIssue = false
 reportMissingImports = false