Improve unexpected error message when build fails#4754
Conversation
|
Thanks for your first PR, @dojutsu-user! One of the maintainers will get to this soon. |
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
I left a comment for the English grammar.
If you think it's acceptable, we need to do the same in the other two places.
| 'Please report this to us with your build id ({build_id}).', | ||
| 'Please try again later. ' | ||
| 'However, if this problem persists, ' | ||
| 'please report to us with your build id ({build_id}).', |
There was a problem hiding this comment.
I said "please report this to us".
I'm not sure if that was important for the grammar, but I just wanted to mention it.
There was a problem hiding this comment.
okay.... that looks more good to me too.
|
@humitos I have corrected the grammar. Please review |
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
Thanks!
This is ready to be merged from my point of view!
|
I'm requesting @davidfischer eyes since he is better than myself with English grammar and communication. |
|
Looks fine to me. :) |
|
💯 Thanks! |
4 participants
Fixes #4751