Skip to content

Commit 2fd2a1b

Browse files
authored
Merge pull request #42 from ruby/feature-16495
[Feature #16495] Do not include a backtick in error messages and backtraces
2 parents 80ede6b + c948016 commit 2fd2a1b

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

test/test_error_highlight.rb

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,31 @@ def teardown
2323
end
2424
end
2525

26+
begin
27+
method_not_exist
28+
rescue NameError
29+
if $!.message.include?("`")
30+
def preprocess(msg)
31+
msg
32+
end
33+
else
34+
def preprocess(msg)
35+
msg.sub("`", "'")
36+
end
37+
end
38+
end
39+
2640
if Exception.method_defined?(:detailed_message)
2741
def assert_error_message(klass, expected_msg, &blk)
2842
omit unless klass < ErrorHighlight::CoreExt
2943
err = assert_raise(klass, &blk)
30-
assert_equal(expected_msg.chomp, err.detailed_message(highlight: false).sub(/ \((?:NoMethod|Name)Error\)/, ""))
44+
assert_equal(preprocess(expected_msg).chomp, err.detailed_message(highlight: false).sub(/ \((?:NoMethod|Name)Error\)/, ""))
3145
end
3246
else
3347
def assert_error_message(klass, expected_msg, &blk)
3448
omit unless klass < ErrorHighlight::CoreExt
3549
err = assert_raise(klass, &blk)
36-
assert_equal(expected_msg.chomp, err.message)
50+
assert_equal(preprocess(expected_msg).chomp, err.message)
3751
end
3852
end
3953

0 commit comments

Comments
 (0)