Skip to content

fix: Fix projects depending on rustc_private hanging#16911

Merged
bors merged 1 commit into
rust-lang:masterfrom
Veykril:rustc-crates
Mar 21, 2024
Merged

fix: Fix projects depending on rustc_private hanging#16911
bors merged 1 commit into
rust-lang:masterfrom
Veykril:rustc-crates

Conversation

@Veykril

@Veykril Veykril commented Mar 21, 2024

Copy link
Copy Markdown
Member

If loading the root fails, we'll hang up in this loop as we never inserted the entry that asserts we already visited a package. This fixes that
Fixes #16902

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2024
@Veykril

Veykril commented Mar 21, 2024

Copy link
Copy Markdown
Member Author

@bors r+

@bors

bors commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 2ad14b8 has been approved by Veykril

It is now in the queue for this repository.

@bors

bors commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2ad14b8 with merge a3d9625...

@bors

bors commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a3d9625 to master...

@bors bors merged commit a3d9625 into rust-lang:master Mar 21, 2024
@Veykril Veykril deleted the rustc-crates branch March 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stuck at "Building CrateGraph" in rust-lang/rust repo

3 participants