refactor(source): Open query API for adding more types of queries#10883
Merged
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
r? @Eh2406 |
Eh2406
reviewed
Jul 20, 2022
Contributor
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2022
Update cargo 5 commits in d8d30a75376f78bb0fabe3d28ee9d87aa8035309..85b500ccad8cd0b63995fd94a03ddd4b83f7905b 2022-07-19 13:59:17 +0000 to 2022-07-24 21:10:46 +0000 - Make the empty rustc-wrapper test more explicit. (rust-lang/cargo#10899) - expand RUSTC_WRAPPER docs (rust-lang/cargo#10896) - Stabilize Workspace Inheritance (rust-lang/cargo#10859) - Fix typo in unstable docs: s/PROGJCT/PROJECT/ (rust-lang/cargo#10890) - refactor(source): Open query API for adding more types of queries (rust-lang/cargo#10883)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This refactors the Source/Registry traits from accepting a
fuzzy: boolto accepting an enum so we can add alternative query styles in the future, as discussed in the Cargo team meeting for fixing #10729The expected fix for
cargo addat this point would beQueryKind::NormalizedExactandFuzzyare used)FuzzytoAlternativesor something to clarify its actual intentHow should we test and review this PR?
The refactor is broken down into multiple commits, so ideally review a commit at a time to more easily see how it evolved.
Additional information
Future possibilities