refactor: Clean up package metadata#12352
Merged
Merged
Conversation
Collaborator
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cfg-expr
weihanglo
approved these changes
Jul 12, 2023
Member
|
Thanks for this! @bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
bors
added a commit
that referenced
this pull request
Jul 12, 2023
refactor: Clean up package metadata ### What does this PR try to resolve? Clean up workspace metadata - Reduce noise by allowing fields to be inferred - I left documentation because that is runtime inferred on crates.io which has trade offs - Default package fields at the workspace level Align us on a single edition ### How should we test and review this PR? Mostly relying on CI for this ### Additional information I noticed this and decided to do this while I was considering the idea of setting an MSRV to "latest" by leveraging #12341 and whether that should just be for `cargo` or for all workspace members. I'm leaning towards all workspace members as that is the only thing we test though strictly speaking people might be able to use lower versions; we just wouldn't officially support it.
Member
|
@bors r- version bump check is failing |
bors
added
S-waiting-on-author
Contributor
|
☀️ Try build successful - checks-actions |
epage
force-pushed
the
meta
branch
3 times, most recently
from
ded239d to
210c817
Compare
Contributor
|
☔ The latest upstream changes (presumably #12361) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
@weihanglo this looks ready if we merge it now and don't sneeze to break it again... |
weihanglo
approved these changes
Jul 17, 2023
weihanglo
approved these changes
Jul 17, 2023
Member
|
Nice! Thank you. @bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2023
Update cargo 11 commits in 694a579566a9a1482b20aff8a68f0e4edd99bd28..1b15556767f4b78a64e868eedf4073c423f02b93 2023-07-11 22:28:29 +0000 to 2023-07-18 14:44:47 +0000 - Fix "cargo doc --open" crash on WSL2 (rust-lang/cargo#12373) - fix(git): respect scp-like URL for nested submodules (rust-lang/cargo#12359) - Upgrade to indexmap v2 (rust-lang/cargo#12368) - refactor: Clean up package metadata (rust-lang/cargo#12352) - Correct unspecifiead to unspecified (rust-lang/cargo#12363) - Replace invalid `panic_unwind` std feature with `panic-unwind` (rust-lang/cargo#12364) - Bump to 0.74.0; update changelog (rust-lang/cargo#12361) - Bump version of crates-io due to unintentional semver-breaking change (rust-lang/cargo#12357) - chore: Automatically update dependencies monthly (rust-lang/cargo#12341) - docs: Use heading attributes to control the fragment. (rust-lang/cargo#12339) - Rustfmt with latest nightly. (rust-lang/cargo#12351) r? ghost
bors
added a commit
that referenced
this pull request
Dec 18, 2023
refactor: clean up package metadata Like #12352 but for `homepage` and `repository`. Inspired by <#13178 (comment)>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Clean up workspace metadata
Align us on a single edition
How should we test and review this PR?
Mostly relying on CI for this
Additional information
I noticed this and decided to do this while I was considering the idea of setting an MSRV to "latest" by leveraging #12341 and whether that should just be for
cargoor for all workspace members. I'm leaning towards all workspace members as that is the only thing we test though strictly speaking people might be able to use lower versions; we just wouldn't officially support it.