Skip to content

Commit bea1d9c

Browse files
Rollup merge of #153020 - GuillaumeGomez:improve-empty-impl-blocks-sentence, r=Urgau
rustdoc: Improve sentence for documented empty impl blocks Part of #152874. An impl block is not necessarily empty, so instead, better to precise that there are no **public** items. r? @Urgau
2 parents b55a3e4 + e628806 commit bea1d9c

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/librustdoc/html/render/mod.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2343,9 +2343,10 @@ fn render_impl_summary(
23432343
if let Some(doc) = doc {
23442344
if impl_is_empty {
23452345
w.write_str(
2346-
"<div class=\"item-info\">\
2347-
<div class=\"stab empty-impl\">This impl block contains no items.</div>\
2348-
</div>",
2346+
"\
2347+
<div class=\"item-info\">\
2348+
<div class=\"stab empty-impl\">This impl block contains no public items.</div>\
2349+
</div>",
23492350
)?;
23502351
}
23512352
write!(w, "<div class=\"docblock\">{doc}</div>")?;

tests/rustdoc-html/impl/empty-impl-block.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
pub struct Foo;
55

66
//@ has - '//*[@class="docblock"]' 'Hello empty impl block!'
7-
//@ has - '//*[@class="item-info"]' 'This impl block contains no items.'
7+
//@ has - '//*[@class="item-info"]' 'This impl block contains no public items.'
88
/// Hello empty impl block!
99
impl Foo {}
1010
// We ensure that this empty impl block without doc isn't rendered.

0 commit comments

Comments
 (0)