Use proper span for break and continue labels

[nagisa]

r? @alexcrichton

[alexcrichton]

@bors: r+ d4921874db5cf5f4e3d2fdd3035926beaa0aa2f8

[nagisa]

Needs re-r+.

[alexcrichton]

@bors: r+ 93a1cbc91ad340b9586740add923832362388b9f

[bors]

🔒 Merge conflict

[nagisa]

rebased

[alexcrichton]

@bors: r+ c493084

[bors]

⌛ Testing commit c493084 with merge 3575f06...

[bors]

⛄ The build was interrupted to prioritize another pull request.

[bors]

⌛ Testing commit c493084 with merge e5c5046...

[bors]

⛄ The build was interrupted to prioritize another pull request.

[Manishearth]

@bors r-

This fails parse tests

[nagisa]

The error:

failures:

---- [parse-fail] parse-fail/removed-syntax-uniq-mut-expr.rs stdout ----

error: unexpected compiler error or warning: '/home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/parse-fail/removed-syntax-uniq-mut-expr.rs:14:25: 14:27 error: expected one of `!`, `.`, `::`, `;`, `{`, or an operator, found `42`'
status: exit code: 101
command: i686-unknown-linux-gnu/stage2/bin/rustc /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/parse-fail/removed-syntax-uniq-mut-expr.rs -L i686-unknown-linux-gnu/test/parse-fail/ --target=i686-unknown-linux-gnu -L i686-unknown-linux-gnu/test/parse-fail/removed-syntax-uniq-mut-expr.stage2-i686-unknown-linux-gnu.parse-fail.libaux -C prefer-dynamic -o i686-unknown-linux-gnu/test/parse-fail/removed-syntax-uniq-mut-expr.stage2-i686-unknown-linux-gnu --cfg rtopt -O -L i686-unknown-linux-gnu/rt -Z parse-only
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
/home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/parse-fail/removed-syntax-uniq-mut-expr.rs:14:21: 14:24 error: expected identifier, found keyword `mut`
/home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/parse-fail/removed-syntax-uniq-mut-expr.rs:14     let a_box = box mut 42;
                                                                                                                                        ^~~
/home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/parse-fail/removed-syntax-uniq-mut-expr.rs:14:25: 14:27 error: expected one of `!`, `.`, `::`, `;`, `{`, or an operator, found `42`
/home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/parse-fail/removed-syntax-uniq-mut-expr.rs:14     let a_box = box mut 42;
                                                                                                                                            ^~

------------------------------------------

thread '[parse-fail] parse-fail/removed-syntax-uniq-mut-expr.rs' panicked at 'explicit panic', /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/compiletest/runtest.rs:1501

The test itself seems to expect errors exactly as emitted. I’m baffled. Are 32bit linux builders broken?
I’m getting seriously annoyed.

[Manishearth]

Could be, not sure. check-stage1 passes fine for me without your PR, so it's either an intermittent, brokenness in the PR, or brokenness introduces in confluence in another PR.

I can't see how this PR could break parsing, though. I'll poke further once I'm sure that the rollup passes check-stage2 locally

[alexcrichton]

@bors: r+ c493084

Let's see what happens outside the rollup

[Manishearth]

@bors p=1

[bors]

⌛ Testing commit c493084 with merge 791e7bc...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt