Skip to content

Add FromIterator implementations for Cow<str>#35064

Merged
bors merged 1 commit into
rust-lang:masterfrom
pthariensflame:feature/cow_str_from_iter
Aug 9, 2016
Merged

Add FromIterator implementations for Cow<str>#35064
bors merged 1 commit into
rust-lang:masterfrom
pthariensflame:feature/cow_str_from_iter

Conversation

@pthariensflame
Copy link
Copy Markdown
Contributor

@pthariensflame pthariensflame commented Jul 27, 2016

This seems like an oversight, since the corresponding implementation for Cow<[T]> where T: Clone exists.

@rust-highfive
Copy link
Copy Markdown
Contributor

rust-highfive commented Jul 27, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rphmeier
Copy link
Copy Markdown
Contributor

rphmeier commented Jul 27, 2016

Would be nice to have an impl<'a, T: 'a, U> FromIterator<U> for Cow<'a, T> where T: ToOwned, T::Owned: FromIterator<U>

but I guess the ship has sailed on that already

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 27, 2016
@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Jul 27, 2016

@rphmeier Wouldn't that be a strict generalization of every current FromIterator impl for Cow? If everyone wants me to, I could do that instead, and just replace the existing impls with the new unified one.

@pthariensflame pthariensflame force-pushed the feature/cow_str_from_iter branch 5 times, most recently from ab328e5 to 61ff591 Compare August 4, 2016 23:16
sfackler
sfackler reviewed Aug 5, 2016
View reviewed changes
Comment thread src/libcollections/borrow.rs Outdated
Copy link
Copy Markdown
Member

@sfackler sfackler Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get rid of this dead code?

Copy link
Copy Markdown
Contributor Author

@pthariensflame pthariensflame Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had included it because of @rphmeier's earlier comment, but I can remove it again.

@sfackler
Copy link
Copy Markdown
Member

sfackler commented Aug 5, 2016

Could you remove the commented out implementation and squash down to one commit? We should be good to merge once that happens.

@pthariensflame pthariensflame force-pushed the feature/cow_str_from_iter branch from 61ff591 to 010e024 Compare August 5, 2016 05:26
@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Aug 5, 2016

@sfackler Done!

@pthariensflame pthariensflame force-pushed the feature/cow_str_from_iter branch from 010e024 to 31d968c Compare August 5, 2016 05:59
@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Aug 7, 2016

@sfackler Any word?

@pthariensflame
Add FromIterator implementations for Cow<str>
42e64bc 
This seems like an oversight, since the corresponding implementation for `Cow<[T]> where T: Clone` exists.
@pthariensflame pthariensflame force-pushed the feature/cow_str_from_iter branch from 31d968c to 42e64bc Compare August 7, 2016 20:41
@alexcrichton
Copy link
Copy Markdown
Member

alexcrichton commented Aug 8, 2016

Discussed at libs traige this this past week the decision was to merge, thanks for the PR @pthariensflame!

@bors: r+ 42e64bc

@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Aug 8, 2016

@alexcrichton Thanks!

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 8, 2016

⌛ Testing commit 42e64bc with merge 080e0e0...

bors added a commit that referenced this pull request Aug 8, 2016
@bors
Auto merge of #35064 - pthariensflame:feature/cow_str_from_iter, r=al…
080e0e0 
…excrichton

Add `FromIterator` implementations for `Cow<str>`

This seems like an oversight, since the corresponding implementation for `Cow<[T]> where T: Clone` exists.
@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 9, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 080e0e0 to master...

@bors bors merged commit 42e64bc into rust-lang:master Aug 9, 2016
@pthariensflame pthariensflame deleted the feature/cow_str_from_iter branch August 9, 2016 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturon aturon

Labels

T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pthariensflame @rust-highfive @rphmeier @sfackler @alexcrichton @bors @aturon