chore: avoid nodejs modules (#487)

* chore: avoid nodejs modules

* Fix no-unresolved errors + address extra lints

---------

Co-authored-by: Colin Casey <casey.colin@gmail.com>

Author: wjhsf

eslint.config.mjs

@@ -2,15 +2,18 @@
 
 import eslint from '@eslint/js'
 import prettierRecommended from 'eslint-plugin-prettier/recommended'
-import tseslint from 'typescript-eslint'
+import { config, configs } from 'typescript-eslint'
+import { flatConfigs as pluginImport } from 'eslint-plugin-import'
 import globals from 'globals'
 
-export default tseslint.config(
+export default config(
   {
     ignores: ['dist', 'jest.config.ts'],
   },
   eslint.configs.recommended,
-  ...tseslint.configs.strictTypeChecked,
+  ...configs.strictTypeChecked,
+  pluginImport.recommended,
+  pluginImport.typescript,
   prettierRecommended,
   {
     languageOptions: {
@@ -25,18 +28,34 @@ export default tseslint.config(
     },
     rules: {
       '@typescript-eslint/explicit-function-return-type': 'error',
+      'import/no-nodejs-modules': 'error',
+    },
+  },
+  {
+    files: ['lib/__tests__/**', 'test/**'],
+    rules: {
+      // We only run tests in node, so we can use node's builtins
+      'import/no-nodejs-modules': 'off',
     },
   },
   {
     // Once we remove the legacy vows tests in ./test, we can remove these JS-specific rules
     files: ['test/**/*.js', 'eslint.config.mjs'],
-    ...tseslint.configs.disableTypeChecked,
+    ...configs.disableTypeChecked,
     rules: {
-      ...tseslint.configs.disableTypeChecked.rules,
+      ...configs.disableTypeChecked.rules,
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-var-requires': 'off',
       '@typescript-eslint/no-unused-vars': 'off',
       '@typescript-eslint/no-require-imports': 'off',
     },
   },
+  {
+    // other configuration are omitted for brevity
+    settings: {
+      'import/resolver': {
+        typescript: {}, // this loads <rootdir>/tsconfig.json to eslint
+      },
+    },
+  },
 )