Merge pull request #266 from paulkaplan/fix-listener-functions

Change #off to #removeListener

Author: paulkaplan

src/containers/blocks.jsx

@@ -56,20 +56,20 @@ class Blocks extends React.Component {
             .getFlyout()
             .getWorkspace()
             .addChangeListener(this.props.vm.flyoutBlockListener);
-        this.props.vm.on('SCRIPT_GLOW_ON', this.onScriptGlowOn);
-        this.props.vm.on('SCRIPT_GLOW_OFF', this.onScriptGlowOff);
-        this.props.vm.on('BLOCK_GLOW_ON', this.onBlockGlowOn);
-        this.props.vm.on('BLOCK_GLOW_OFF', this.onBlockGlowOff);
-        this.props.vm.on('VISUAL_REPORT', this.onVisualReport);
-        this.props.vm.on('workspaceUpdate', this.onWorkspaceUpdate);
+        this.props.vm.addListener('SCRIPT_GLOW_ON', this.onScriptGlowOn);
+        this.props.vm.addListener('SCRIPT_GLOW_OFF', this.onScriptGlowOff);
+        this.props.vm.addListener('BLOCK_GLOW_ON', this.onBlockGlowOn);
+        this.props.vm.addListener('BLOCK_GLOW_OFF', this.onBlockGlowOff);
+        this.props.vm.addListener('VISUAL_REPORT', this.onVisualReport);
+        this.props.vm.addListener('workspaceUpdate', this.onWorkspaceUpdate);
     }
     detachVM () {
-        this.props.vm.off('SCRIPT_GLOW_ON', this.onScriptGlowOn);
-        this.props.vm.off('SCRIPT_GLOW_OFF', this.onScriptGlowOff);
-        this.props.vm.off('BLOCK_GLOW_ON', this.onBlockGlowOn);
-        this.props.vm.off('BLOCK_GLOW_OFF', this.onBlockGlowOff);
-        this.props.vm.off('VISUAL_REPORT', this.onVisualReport);
-        this.props.vm.off('workspaceUpdate', this.onWorkspaceUpdate);
+        this.props.vm.removeListener('SCRIPT_GLOW_ON', this.onScriptGlowOn);
+        this.props.vm.removeListener('SCRIPT_GLOW_OFF', this.onScriptGlowOff);
+        this.props.vm.removeListener('BLOCK_GLOW_ON', this.onBlockGlowOn);
+        this.props.vm.removeListener('BLOCK_GLOW_OFF', this.onBlockGlowOff);
+        this.props.vm.removeListener('VISUAL_REPORT', this.onVisualReport);
+        this.props.vm.removeListener('workspaceUpdate', this.onWorkspaceUpdate);
     }
     onWorkspaceMetricsChange () {
         const target = this.props.vm.editingTarget;

src/containers/green-flag.jsx

@@ -16,12 +16,12 @@ class GreenFlag extends React.Component {
         this.state = {projectRunning: false};
     }
     componentDidMount () {
-        this.props.vm.on('PROJECT_RUN_START', this.onProjectRunStart);
-        this.props.vm.on('PROJECT_RUN_STOP', this.onProjectRunStop);
+        this.props.vm.addListener('PROJECT_RUN_START', this.onProjectRunStart);
+        this.props.vm.addListener('PROJECT_RUN_STOP', this.onProjectRunStop);
     }
     componentWillUnmount () {
-        this.props.vm.off('PROJECT_RUN_START', this.onProjectRunStart);
-        this.props.vm.off('PROJECT_RUN_STOP', this.onProjectRunStop);
+        this.props.vm.removeListener('PROJECT_RUN_START', this.onProjectRunStart);
+        this.props.vm.removeListener('PROJECT_RUN_STOP', this.onProjectRunStop);
     }
     onProjectRunStart () {
         this.setState({projectRunning: true});

src/containers/stop-all.jsx

@@ -15,12 +15,12 @@ class StopAll extends React.Component {
         this.state = {projectRunning: false};
     }
     componentDidMount () {
-        this.props.vm.on('PROJECT_RUN_START', this.onProjectRunStart);
-        this.props.vm.on('PROJECT_RUN_STOP', this.onProjectRunStop);
+        this.props.vm.addListener('PROJECT_RUN_START', this.onProjectRunStart);
+        this.props.vm.addListener('PROJECT_RUN_STOP', this.onProjectRunStop);
     }
     componentWillUnmount () {
-        this.props.vm.off('PROJECT_RUN_START', this.onProjectRunStart);
-        this.props.vm.off('PROJECT_RUN_STOP', this.onProjectRunStop);
+        this.props.vm.removeListener('PROJECT_RUN_START', this.onProjectRunStart);
+        this.props.vm.removeListener('PROJECT_RUN_STOP', this.onProjectRunStop);
     }
     onProjectRunStart () {
         this.setState({projectRunning: true});