Skip to content

Commit e9b56d8

Browse files
authored
feat: Upgrade node-hcl to version that supports merging tfvars files (#80)
* feat(hcl): upgrade node-hcl to version that supports merging tfvars files BREAKING CHANGE: Upgrade node-hcl to verison 2.0.0
1 parent b27d56c commit e9b56d8

4 files changed

Lines changed: 6 additions & 11 deletions

File tree

.github/workflows/pr-title-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2020
with:
2121
# Configure types to match semantic-release rules from package.json
22-
types: >
22+
types: |
2323
feat
2424
fix
2525
docs

plugins/scaffolder-backend-module-hcl/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"@backstage/config": "^1.2.0",
3434
"@backstage/plugin-scaffolder-node": "^0.4.10",
3535
"@backstage/types": "^1.2.0",
36-
"@seatgeek/node-hcl": "^1.0.0",
36+
"@seatgeek/node-hcl": "^2.0.0",
3737
"fs-extra": "^11.2.0",
3838
"zod": "^3.23.8"
3939
},

plugins/scaffolder-backend-module-hcl/src/actions/hcl/hcl.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ describe('createHclMergeAction', () => {
5757
}
5858
type = string
5959
}
60-
6160
`;
6261

6362
const mockCtx = {
@@ -106,7 +105,6 @@ describe('createHclMergeAction', () => {
106105
}
107106
type = string
108107
}
109-
110108
`;
111109

112110
const mockCtx = {
@@ -158,7 +156,6 @@ describe('createHclMergeFilesAction', () => {
158156
description = "Name to be used on all the resources as identifier"
159157
type = string
160158
}
161-
162159
`;
163160

164161
const aPath = `${mockContext.workspacePath}/${randomBytes(12).toString(
@@ -252,7 +249,6 @@ describe('createHclMergeFilesAction', () => {
252249
}
253250
}
254251
255-
256252
module "my_module" {
257253
my_map = {
258254
"map_a" = {
@@ -269,7 +265,6 @@ module "my_module" {
269265
var = local.my_var
270266
version = "0.0.2"
271267
}
272-
273268
`;
274269

275270
const aPath = `${mockContext.workspacePath}/${randomBytes(12).toString(

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9595,10 +9595,10 @@
95959595
version "0.0.0"
95969596
uid ""
95979597

9598-
"@seatgeek/node-hcl@^1.0.0":
9599-
version "1.1.1"
9600-
resolved "https://registry.yarnpkg.com/@seatgeek/node-hcl/-/node-hcl-1.1.1.tgz#13e9a2127a665d8ebedeed31c28e7e4aef6033cc"
9601-
integrity sha512-pvqj6rzI8sG8/O62vcaj4WL4F6eQSVStGE+97GAONk1a8WLwL4yF68MXo8hfzUSsN+ljUTMoF1qnJECpHpAyLg==
9598+
"@seatgeek/node-hcl@^2.0.0":
9599+
version "2.0.0"
9600+
resolved "https://registry.yarnpkg.com/@seatgeek/node-hcl/-/node-hcl-2.0.0.tgz#ca0d538bbd99b501a5cf20c0c83d913c791109df"
9601+
integrity sha512-f4B9DFVjAcXlEYQVxsWSvXYKPZLhds4nZQ0fSeqW0c+Q+xdjg296CmtjxOsvOt2tip6q6KtmJPejxXQ2C/gceA==
96029602
dependencies:
96039603
fs-extra "^11.2.0"
96049604

0 commit comments

Comments
 (0)