feat: add callbacks to appsflyer plugin#1053
Merged
alanjcharles merged 1 commit intosegmentio:masterfrom May 19, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes the three callbacks used in the appsflyer plugin out of the plugin as props.
Appsflyer docs mention that the
onDeepLinkcallback must be configured before initializing the SDK and as far as my testing goes, the callback cannot be defined more than once per SDK instance.By adding props for the used callbacks, it's possible to use the callback logic used by the plugin and still specify custom deep link handlers.
Let me know if I'm missing something or if there is a better or easier way to solve this!