feat: add support for test files colocated with models#1187
Merged
WikiRik merged 1 commit intosequelize:mainfrom Nov 5, 2022
Merged
Conversation
Contributor
Author
|
i looked for a file with relevant test cases for this code but couldn't find it. If anyone knows where this logic is tested i'm happy to add additional test cases in there |
WikiRik
approved these changes
Nov 5, 2022
Member
WikiRik
left a comment
There was a problem hiding this comment.
I'm also not sure how to test this, but I think we can look into that later. Thanks for this PR!
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 3, 2024
This was referenced Aug 11, 2024
This was referenced Aug 18, 2024
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
This was referenced Sep 26, 2024
This was referenced Oct 3, 2024
This was referenced Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testpass with this change (including linting)?Description of change
The models/index.js file is an auto-generated file used to automatically register all models from the models folder
It works under the assumption that the only files you have in your /models folder are models.
This works for most of the cases, but it causes an issue for projects using tests colocated with the tested file, e.g.
for such cases, if you want to add unit tests, you would have to either move to a symmetric /tests folder that replicates the structure of your project (for example as this project does), or follow this approach only for the models folder (quite inconsistent), or not write tests for models (quite bad)
This PR addresses the issue by adding a condition that will skip filenames containing
.test.js.