fix: only show error detail when error.original is defined#1241
Merged
WikiRik merged 2 commits intosequelize:mainfrom Jan 25, 2023
Merged
fix: only show error detail when error.original is defined#1241WikiRik merged 2 commits intosequelize:mainfrom
WikiRik merged 2 commits intosequelize:mainfrom
Conversation
WikiRik
requested changes
Jan 25, 2023
Member
WikiRik
left a comment
There was a problem hiding this comment.
Sorry, approved too quickly. We still support Node 10 which does not have the optional chaining
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 3, 2024
This was referenced Aug 11, 2024
This was referenced Aug 18, 2024
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
This was referenced Sep 26, 2024
This was referenced Oct 3, 2024
This was referenced Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testpass with this change (including linting)?Description of change
Using
"sequelize-cli": "6.5.2",When
uphandler of a migration throws a custom error.The cli throws the following error
The error originates from this line:
In this PR we change the IF condition to check if the original field is set so the error will not occur.